1671952 - Turn off bookmarks 2020h2 pref on beta 83

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[:Gijs (he/him)]

[Tracking Requested - why for this release]:

For the bookmarks work in bug 1665353, we put everything behind a pref.

That pref is enabled in "early beta or earlier", which is what we did with the shirley work.

However, right now there's only 1 thing that made the 83 beta cycle, which is bug 1328637.

Unfortunately, that means that the shortcut for the library window is changing on beta mid-cycle, and the shortcut for the bookmarks toolbar will go back to opening the library instead.

This is unfortunate, and not really useful in terms of early testing. It seems better to disable this work on beta entirely.

bug 1671587 will start failing when we do that, if we don't fix or disable the test.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1671952 - turn off the 2020h2 bookmarks pref on non-nightly, r?jaws

Depends on D94030

Comment 2

[:Gijs (he/him)]

Comment on attachment 9182441 [details]
Bug 1671952 - turn off the 2020h2 bookmarks pref on non-nightly, r?jaws

Beta/Release Uplift Approval Request

• User impact if declined: confusing user experience on beta
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1671587
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's just a pref flip
• String changes made/needed: no

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9182441 [details]
Bug 1671952 - turn off the 2020h2 bookmarks pref on non-nightly, r?jaws

Approved for beta 1

Comment 4

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6cb4495f3c94

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7c822a9dc46
turn off the 2020h2 bookmarks pref on non-nightly, r=jaws

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b7c822a9dc46