1671973 - Add a test to check that DevTools forceReload bypasses the cache

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1671959

DevTools are forwarding reload shortcuts to the browser, however we regressed the "force reload" in Bug 1465635.

The issue is fixed in Bug 1671959, however we should add a test to avoid regressing this again. I am surprised we didn't get more bugs from this, maybe users are just generally unsure about what the browser does for a given reload shortcut and didn't think DevTools were to blame?

Comment 1

[Julian Descottes [:jdescottes]]

Note that we have a test for reload at https://searchfox.org/mozilla-central/source/devtools/client/framework/test/browser_toolbox_window_reload_target.js. It checks the "forceReload" shortcuts but it only checks the page is reloaded, and doesn't check if the LOAD_FLAGS_BYPASS_CACHE flag was passed. I didn't see any easy way to modify the test to do that, which is why I file this as a followup.

If we can't find a way to check the reload flags, we just need to test a scenario where a forceReload will have a visible impact (eg netmonitor without the "disable cache" option).

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1671973 - [devtools] Add a test to check that DevTools forceReload bypasses the cache

This is a test for the bug fix that landed in https://bugzilla.mozilla.org/show_bug.cgi?id=1671959

A new test is added, forked from devtools/client/framework/test/browser_toolbox_window_reload_target.js
Most of the testReload helper from the original test is moved to the head.js of the folder.

The new test relies on a simple sjs file which simply prints the value of the cache-control header.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be30ef2e6513
[devtools] Add a test to check that DevTools forceReload bypasses the cache r=nchevobbe

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/be30ef2e6513