Roll20 "Dynamic Lighting" is slow
Categories
(Core :: Graphics: CanvasWebGL, defect, P3)
Tracking
()
People
(Reporter: alexical, Unassigned)
Details
So, roll20 seems to be doing A Bad Thing and implementing their dynamic lighting overlay as a texture that just gets updated every frame. Anyway, it nevertheless runs quite smoothly for Chrome, but it hits us hard inside WebGLImageConverter::run (profile). It's converting BGRA8 to RGBA8 and doing a premultiply. It makes sense that this is slow, but it could be faster - looking at the disassembly I don't see any vectorization going on, but it looks like something that wouldn't be too crazy with just SSE2 instructions? I'm not sure what our SIMD story is at Mozilla though. It also seems trivially parallelizable? Not sure quite how much we care.
|
||
Comment 1•5 years ago
|
||
The severity field is not set for this bug.
:jgilbert, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Comment 2•5 years ago
|
||
There's a plan to do these conversions gpu-side, but we don't want to get into the SSE weeds.
Any way you slice it, they're asking us for a slow thing, and even if Chrome makes it tolerably fast, it'd be faster still to do it properly. S4/P3
Description
•