[wpt-sync] Sync PR 26149 - Synchronize classList on SVGElement.className.baseVal updates
Categories
(Core :: SVG, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 26149 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/26149
Details from upstream follow.
b'Fredrik S\xc3\xb6derqvist <fs@opera.com>' wrote:
Synchronize classList on SVGElement.className.baseVal updates
Element.classList is normally updated by AttributeChanged(). When the
underlying attribute is updated via the corresponding SVG animated
property AttributeChanged() is not invoked, which makes the list and
attribute go out of sync.Refactor baseVal updates on SVGElement so that they go through a single
entry point by renaming SvgAttributeBaseValChanged() to
BaseValueChanged() and folding it into the other user
(SVGElement::AttributeChanged). Fold InvalidateSVGAttributes() into
BaseValueChanged() since it's the only caller.BaseValueChanged() is then updated to update the classList when the
className base value is updated. Move the classList update into a shared
Element::UpdateClassList() function.Fixed: 1137953
Change-Id: I64efff0bfd163b14eb937c635c3d170b4511f4a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480023
Commit-Queue: Fredrik Söderquist \<fs@opera.com>
Reviewed-by: Stephen Chenney \<schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818035}
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a71e8832d89db3f8520185ed272167fd5e5f166
Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 1 subtests
Status Summary
Firefox
OK : 1
PASS: 1
Chrome
OK : 1
FAIL: 1
Safari
OK : 1
PASS: 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c859f993040e [wpt PR 26149] - Synchronize classList on SVGElement.className.baseVal updates, a=testonly
Comment 4•4 years ago
|
||
bugherder |
Description
•