Closed Bug 1672022 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26154 - Fix AtomicStringTable lowercase translator.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26154 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26154
Details from upstream follow.

b'Jeremy Roman <jbroman@chromium.org>' wrote:

Fix AtomicStringTable lowercase translator.

It was erroneously checking if a candidate entry in the atomic string
table was an existing lowercase version of the provided string by
comparing the two strings for lower-ASCII equality, but this doesn't
imply that the string found in the atomic string table is lowercase
ASCII.

For urgent merging to release branches, this is a minimal fix.
A followup CL will land a more efficient version of this.

Bug: 1138487
Change-Id: I3af7411879ea831c9210e43cee16bca607b51b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480844
Reviewed-by: Daniel Cheng \<dcheng@chromium.org>
Reviewed-by: Mason Freed \<masonfreed@chromium.org>
Commit-Queue: Jeremy Roman \<jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818060}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b1ad2471e23 [wpt PR 26154] - Fix AtomicStringTable lowercase translator., a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.