Closed Bug 1672040 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26161 - [layout] Fix OOF replaced elements with display: table.

Categories

(Core :: Layout: Positioned, task, P4)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26161 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26161
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[layout] Fix OOF replaced elements with display: table.

Previously we had special logic within ng_absolute_utils.cc which simply
checked if we had an element with display:table for some table specific
logic.

This was incorrect, and should have been checking for the LayoutObject
type instead.
This caused some incorrect layout of replaced elements when OOF.

This patch uses the NGBlockNode::IsTable instead to apply this logic.

Bug: 1138851
Change-Id: Id428df4f48c48ad949bd3d8ffce70827e8809081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483962
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Reviewed-by: Christian Biesinger \<cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818448}

Component: web-platform-tests → Layout: Positioned
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/29c2f4c65d1e [wpt PR 26161] - [layout] Fix OOF replaced elements with display: table., a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.