Closed Bug 1672042 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26147 - [AspectRatio] Correctly compute flex line length

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26147 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26147
Details from upstream follow.

b'Christian Biesinger <cbiesinger@chromium.org>' wrote:

[AspectRatio] Correctly compute flex line length

Because flexbox passes in LayoutUnit::Max(), ng_length_utils used
that as the minimum block size, so effectively we ignored the
aspect ratio.

The test was incorrect. See also https://github.com/w3c/csswg-drafts/issues/5406

R=ikilpatrick@chromium.org, mstensho@chromium.org

Bug: 1083010, 1045668
Change-Id: I2ed30cb6d9539ea82ac5c22b34c45770fa9a60a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479802
Auto-Submit: Christian Biesinger \<cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger \<cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818452}

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-sizing/aspect-ratio/flex-aspect-ratio-008.tentative.html: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eda7db9ee3cb
[wpt PR 26147] - [AspectRatio] Correctly compute flex line length, a=testonly
https://hg.mozilla.org/integration/autoland/rev/65c0313a2663
[wpt PR 26147] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/eda7db9ee3cb
https://hg.mozilla.org/mozilla-central/rev/65c0313a2663

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.