Closed Bug 1672046 Opened 1 month ago Closed 1 month ago

Progress updates lost (only 15 and 100 are received)

Categories

(GeckoView :: General, defect, P1)

Unspecified
All

Tracking

(firefox81 unaffected, firefox82 wontfix, firefox83 fixed, firefox84 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
firefox81 --- unaffected
firefox82 --- wontfix
firefox83 --- fixed
firefox84 --- fixed

People

(Reporter: csadilek, Assigned: agi)

References

(Regression)

Details

(Keywords: perf-alert, Whiteboard: [geckoview:m84])

Attachments

(1 file)

This seems to be a regression in GV 82.

STR:

  • Load any page
  • Observe onProgressChange 15
  • Observe onProgressChange 100

In 81 and before we received onProgressChange calls for 55 and 80 as well. This is causing the progress bar in Fenix to never finish and hurts perceived performance.

Assignee: nobody → agi
Priority: -- → P1
Regressed by: 1648154
Whiteboard: [geckoview:m84]
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1b2c2d5b290
Use correct URI from Event in GeckoViewProgress. r=esawin
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Comment on attachment 9182498 [details]
Bug 1672046 - Use correct URI from Event in GeckoViewProgress.

Beta/Release Uplift Approval Request

  • User impact if declined: The progress bar will linger a lot longer than usual on some website negatively affecting perceived performance.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Visit cnn.com, the progress bar should disappear as soon as the page is visible or before.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The fix is trivial and contained to the progress measurement code
  • String changes made/needed:
Attachment #9182498 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9182498 [details]
Bug 1672046 - Use correct URI from Event in GeckoViewProgress.

82 regression, small patch, approved for 83 beta 2, thanks.

Attachment #9182498 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified as fixed on Firefox Preview Nightly 201025 (Build #2015771787) using a OnePlus 6T (Android 9) and Samsung Galaxy S9 (Android 8.0.0).

Flags: qe-verify+

== Change summary for alert #27322 (as of Fri, 23 Oct 2020 05:37:42 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
8% instagram ContentfulSpeedIndex android-hw-g5-7-0-arm7-api-16-shippable cold 1,021.67 -> 942.83

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=27322

Keywords: perf-alert
You need to log in before you can comment on or make changes to this bug.