1672046 - Progress updates lost (only 15 and 100 are received)

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Christian Sadilek [:csadilek]]

This seems to be a regression in GV 82.

STR:

• Load any page
• Observe onProgressChange 15
• Observe onProgressChange 100

In 81 and before we received onProgressChange calls for 55 and 80 as well. This is causing the progress bar in Fenix to never finish and hurts perceived performance.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1672046 - Use correct URI from Event in GeckoViewProgress.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1b2c2d5b290
Use correct URI from Event in GeckoViewProgress. r=esawin

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d1b2c2d5b290

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Comment on attachment 9182498 [details]
Bug 1672046 - Use correct URI from Event in GeckoViewProgress.

Beta/Release Uplift Approval Request

• User impact if declined: The progress bar will linger a lot longer than usual on some website negatively affecting perceived performance.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Visit cnn.com, the progress bar should disappear as soon as the page is visible or before.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is trivial and contained to the progress measurement code
• String changes made/needed:

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9182498 [details]
Bug 1672046 - Use correct URI from Event in GeckoViewProgress.

82 regression, small patch, approved for 83 beta 2, thanks.

Comment 6

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/87778c076580

Comment 7

[Laurentiu Apahidean]

Verified as fixed on Firefox Preview Nightly 201025 (Build #2015771787) using a OnePlus 6T (Android 9) and Samsung Galaxy S9 (Android 8.0.0).

Comment 8

[Florin Strugariu [:Bebe]]

== Change summary for alert #27322 (as of Fri, 23 Oct 2020 05:37:42 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
8%	instagram	ContentfulSpeedIndex	android-hw-g5-7-0-arm7-api-16-shippable	cold	1,021.67 -> 942.83

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=27322