1672140 - Find better naming for mozilla::dom::cache::QuotaInfo vs. mozilla::dom::quota::QuotaInfo

Status: RESOLVED FIXED

(Core :: Storage: Cache API, task)

Description

[Simon Giesecke [:sg] [he/him]]

In both mozilla::dom::cache and mozilla::dom::quota, we have types called QuotaInfo, where the former subclasses the latter. The naming is quite generic, and probably at least one of the classes should be renamed.

Comment 1

[Jan Varga [:janv]]

There's no mozilla::dom::quota::QuotaInfo anymore, it's been renamed to mozilla::dom::quota::OriginMetadata.
However the one in cache should be renamed still I think and the inheritance can be changed from OriginMetadata to ClientMetadata.

Comment 2

[Haiyang Xu]

Attachment: Bug 1672140 - Rename cache::QuotaInfo to cache::ClientMetadata and rename corresponding functions; r=#dom-storage

Comment 3

[Haiyang Xu]

Attachment: Bug 1672140 - Change cache::ClientMetadata's base class from quota::OriginMetadata to quota::ClientMetadata; r=#dom-storage-reviewers

Depends on D125583

Comment 4

[Haiyang Xu]

Attachment: Bug 1672140 - Rename cache::ClientMetadata to cache::CacheDirectoryMetadata; r=#dom-storage-reviewers

Depends on D126056

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/396640d13ece
Rename cache::QuotaInfo to cache::ClientMetadata and rename corresponding functions; r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/549556f430a7
Change cache::ClientMetadata's base class from quota::OriginMetadata to quota::ClientMetadata; r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/32edbc243607
Rename cache::ClientMetadata to cache::CacheDirectoryMetadata; r=dom-storage-reviewers,janv

Comment 6

[Atila Butkovits]

Backed out for causing Bp-hybrid build bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/474fe4e3dd2462465d5c86a46a915ff0ccb6285b

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=YUQJUNjvSmiq87oe2uVFAQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=32edbc243607a5ffaf19797c0ac8a89da0b4abba

Failure log: https://treeherder.mozilla.org/logviewer?job_id=358992437&repo=autoland&lineNumber=80893

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efab0b5de6f8
Rename cache::QuotaInfo to cache::ClientMetadata and rename corresponding functions; r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/babad44d2c1f
Change cache::ClientMetadata's base class from quota::OriginMetadata to quota::ClientMetadata; r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/5994ceff9c9a
Rename cache::ClientMetadata to cache::CacheDirectoryMetadata; r=dom-storage-reviewers,janv

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/efab0b5de6f8
https://hg.mozilla.org/mozilla-central/rev/babad44d2c1f
https://hg.mozilla.org/mozilla-central/rev/5994ceff9c9a

Comment 9

[Haiyang Xu]

Build error fixed by the latest revision.