1672285 - GV now needs to set browser.tabs.remote.autostart in its default prefs

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1672285: Set browser.tabs.remote.autostart = true in geckoview-prefs; r=#geckoview-reviewers

We used to do this as part of requesting multiprocess in runtime settings, but
now that e10s is default, we need to set it here.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 9182775 [details]
Bug 1672285: Set browser.tabs.remote.autostart = true in geckoview-prefs; r=#geckoview-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: e10s won't work correctly
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch, default pref flip
• String changes made/needed:

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1095a37e17c
Set browser.tabs.remote.autostart = true in geckoview-prefs; r=geckoview-reviewers,agi

Comment 4

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=W9-bcCLwRGuT5G63hwJEEw.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cxpcshell%2Ctests%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-xpcshell-e10s%2Cx4&revision=c1095a37e17c5f49dcd338ff0c5f85498c6390a9

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319204606&repo=autoland&lineNumber=1861
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319205171&repo=autoland&lineNumber=1965

Backout: https://hg.mozilla.org/integration/autoland/rev/8dbba1ce63e803c5a14bd92ce8f49541760a46f6

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

I'm just going to close this out and land this fix with the original patchset.