Closed Bug 1672299 Opened 11 months ago Closed 11 months ago

JavaScript error: chrome://global/content/elements/panel.js, line 106: TypeError: can't access property "alignmentPosition", event is undefined

Categories

(Thunderbird :: General, defect)

x86_64
Linux
defect

Tracking

(thunderbird_esr78 unaffected, thunderbird83 wontfix)

RESOLVED FIXED
84 Branch
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird83 --- wontfix

People

(Reporter: ishikawa, Assigned: mkmelin)

Details

Attachments

(1 file)

I see the following message in my local mochitest log produced by
running FULL debug version of C-C TB.

 31 JavaScript error: chrome://global/content/elements/panel.js, line 106: TypeError: can't access property "alignmentPosition", event is undefined

31 at the beginning is the number of appearances in the log.

This is relatively new, I don't see it in the local log dated Sept 29,
but the errors were visible in local logs dated Oct 18 onward.
So it appeared somewhere in between.

The test that produces the message is
as follows.
40:17.16 TEST_START: comm/mail/base/test/browser/browser_mailContext.js
53:26.49 TEST_START: comm/mail/components/extensions/test/browser/browser_ext_browserAction.js
53:40.60 TEST_START: comm/mail/components/extensions/test/browser/browser_ext_commands_execute_browser_action.js
53:56.82 TEST_START: comm/mail/components/extensions/test/browser/browser_ext_composeAction.js
58:42.84 TEST_START: comm/mail/components/extensions/test/browser/browser_ext_messageDisplayAction.js

The same error is visible in other people's try-comm-central server
run as well.
For example, see the linux 64 debug version test runs.

Wed, Oct 21, 05:38:16 - lasana@thunderbird.net
https://firefoxci.taskcluster-artifacts.net/HHSmuYviSZW5fh3s2GriRg/0/public/logs/live_backing.log

Tue, Oct 20, 20:05:57 - remotenonsense@gmail.com
https://firefoxci.taskcluster-artifacts.net/ADN3CeOTSXqxilbBzW_oiw/0/public/logs/live_backing.log

(Tough, the test logs are now split into multiple files and so the errors are spread over
multiple files. This has been like this for some time. I wonder what
is the rationale behind this.)

Not sure this is correct.I don't really know if the event would be triggered/handled automatically either. But at least what's there now won't work, after the commit in my previous comment.

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9182868 - Flags: review?(geoff)

It looks the change in comment 1 was necessitated from the transition from XUL to XHTML which resulted in the undesirable drawing order of popup related items.
It is tough to see such a change affecting TB in an unexpected manner.
(It would have been great to have a core utility that is assembled in small number of files that can hide such changes internally, i.e., when a change occurs the necessary changes to accommodate the initial change are contained in the core subset. Of course, it is easier said than done.)

Transition to XUL would bring more such changes, I am afraid...

Comment on attachment 9182868 [details] [diff] [review]
bug1672299_panel_alignmentPosition.patch

The Firefox version of this file doesn't have this line any more either, so I guess this is fine.

Attachment #9182868 - Flags: review?(geoff) → review+

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/ec15afc1e9e3
drop panel.adjustArrowPosition call in resizeBrowser. r=darktrojan DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.