Closed Bug 1672369 Opened 2 years ago Closed 2 years ago

Provide more details on shutdown progress when shutdown times out

Categories

(Core :: Storage: Quota Manager, task)

task

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: sg, Assigned: sg)

References

(Blocks 1 open bug)

Details

Attachments

(8 files)

No description provided.
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2697e316dea1
Pull up common ShutdownWorkThreads into QuotaClient. r=dom-workers-and-storage-reviewers,ttung,janv
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

I assume, the other patches should land some day, too.

Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
See Also: → 1679425
Attachment #9189834 - Flags: data-review?(tdsmith)

Comment on attachment 9189834 [details]
Data review for quota shutdown timeout crash annotation.txt

A couple notes:

  • Since this affects ping: true annotations, toolkit/components/telemetry/docs/data/crash-ping.rst should be updated as well
  • If you care about seeing these annotations in crash pings in BigQuery, the new annotations need to be added to mozilla-pipeline-schemas; bug 1631506 points to a script that you can run, or you can open a data platform bug for it.
  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in the crash annotations definition list.

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out for crash pings, and choosing whether to send a crash report or not.

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Jan Varga and Simon Giesecke.

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Cat 1, technical data.

  1. Is the data collection request for default-on or default-off?

Default-on.

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes.

  1. Does there need to be a check-in in the future to determine whether to renew the data?

n/a, permanent collection

  1. Does the data collection use a third-party collection tool?

No.

Attachment #9189834 - Flags: data-review?(tdsmith) → data-review+
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f66a73bdbb68
Unify handling shutdown timeout of quota clients. r=dom-workers-and-storage-reviewers,ttung,janv
https://hg.mozilla.org/integration/autoland/rev/9a812031caa3
Change infallible TypeToText to use a return value and remove unused variant. r=dom-workers-and-storage-reviewers,ttung,janv
https://hg.mozilla.org/integration/autoland/rev/34b0c6b141bc
Add ability to record intermediate shutdown steps for timeout analysis. r=dom-workers-and-storage-reviewers,ttung,janv
https://hg.mozilla.org/integration/autoland/rev/d8f5b6ac965f
Record IndexedDB shutdown steps. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/238ad66372c0
Record Cache API shutdown steps. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/3e8bb4808759
Record localstorage shutdown steps. r=dom-workers-and-storage-reviewers,janv
Keywords: leave-open
Regressions: 1681087
Depends on: 1693116
You need to log in before you can comment on or make changes to this bug.