1672369 - Provide more details on shutdown progress when shutdown times out

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1672369 - Pull up common ShutdownWorkThreads into QuotaClient. r=#dom-workers-and-storage

Depends on D94138

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1672369 - Unify handling shutdown timeout of quota clients. r=#dom-workers-and-storage

Depends on D94298

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1672369 - Change infallible TypeToText to use a return value and remove unused variant. r=#dom-workers-and-storage

Depends on D94318

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1672369 - Add ability to record intermediate shutdown steps for timeout analysis. r=#dom-workers-and-storage

Depends on D94319

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1672369 - Record IndexedDB shutdown steps. r=#dom-workers-and-storage

Depends on D94333

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1672369 - Record Cache API shutdown steps. r=#dom-workers-and-storage

Depends on D94594

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1672369 - Record localstorage shutdown steps. r=#dom-workers-and-storage

Depends on D94740

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2697e316dea1
Pull up common ShutdownWorkThreads into QuotaClient. r=dom-workers-and-storage-reviewers,ttung,janv

Comment 9

[Simon Giesecke [:sg] [he/him]]

Attachment: Data review for quota shutdown timeout crash annotation.txt

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2697e316dea1

Comment 11

[Jens Stutte [:jstutte]]

I assume, the other patches should land some day, too.

Comment 12

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9189834 [details]
Data review for quota shutdown timeout crash annotation.txt

A couple notes:

• Since this affects ping: true annotations, toolkit/components/telemetry/docs/data/crash-ping.rst should be updated as well
• If you care about seeing these annotations in crash pings in BigQuery, the new annotations need to be added to mozilla-pipeline-schemas; bug 1631506 points to a script that you can run, or you can open a data platform bug for it.

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in the crash annotations definition list.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out for crash pings, and choosing whether to send a crash report or not.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Jan Varga and Simon Giesecke.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Cat 1, technical data.

5. Is the data collection request for default-on or default-off?

Default-on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does there need to be a check-in in the future to determine whether to renew the data?

n/a, permanent collection

9. Does the data collection use a third-party collection tool?

No.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f66a73bdbb68
Unify handling shutdown timeout of quota clients. r=dom-workers-and-storage-reviewers,ttung,janv
https://hg.mozilla.org/integration/autoland/rev/9a812031caa3
Change infallible TypeToText to use a return value and remove unused variant. r=dom-workers-and-storage-reviewers,ttung,janv
https://hg.mozilla.org/integration/autoland/rev/34b0c6b141bc
Add ability to record intermediate shutdown steps for timeout analysis. r=dom-workers-and-storage-reviewers,ttung,janv
https://hg.mozilla.org/integration/autoland/rev/d8f5b6ac965f
Record IndexedDB shutdown steps. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/238ad66372c0
Record Cache API shutdown steps. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/3e8bb4808759
Record localstorage shutdown steps. r=dom-workers-and-storage-reviewers,janv

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f66a73bdbb68
https://hg.mozilla.org/mozilla-central/rev/9a812031caa3
https://hg.mozilla.org/mozilla-central/rev/34b0c6b141bc
https://hg.mozilla.org/mozilla-central/rev/d8f5b6ac965f
https://hg.mozilla.org/mozilla-central/rev/238ad66372c0
https://hg.mozilla.org/mozilla-central/rev/3e8bb4808759