1672372 - Silence warning in IntermNode.h

Status: NEW

(Core :: Graphics, task)

Description

[Simon Giesecke [:sg] [he/him]]

There are many instances of this warning in the build:

 2:59.16 /home/simon/work/refactor/gfx/angle/checkout/src/compiler/translator/IntermNode.h:916:37: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
 2:59.16     ~TIntermPreprocessorDirective() final;
 2:59.16                                     ^
 2:59.16 /home/simon/work/refactor/gfx/angle/checkout/src/compiler/translator/IntermNode.h:911:7: note: mark 'sh::TIntermPreprocessorDirective' as 'final' to silence this warning
 2:59.16 class TIntermPreprocessorDirective : public TIntermNode
 2:59.16       ^

Can this warning be silenced by either disabling this for this file, or by following the advice given in the diagnostic?

Comment 1

[Jeff Muizelaar [:jrmuizel]]

This is fixed in upstream ANGLE. We'll get it on the next ANGLE update. Jeff do you know when that will be?

Comment 2

[Kelsey Gilbert [:jgilbert]]

No current plan, but we can probably do one in 84, or failing that 85.

Comment 3

[Markus Stange [:mstange]]

This is still happening.