Closed Bug 1672430 Opened 4 years ago Closed 3 years ago

Remove workaround for duplicate STATE_START events when switching process

Categories

(GeckoView :: General, defect)

Product:
GeckoView
Component:
General
Platform:
Unspecified
All
Type:
defect

Tracking

(firefox85 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox85 --- fixed

People

(Reporter: agi, Unassigned)

Details

When switching process, we see multiple on start events. This makes the progress bar flicker.

We listen using these flags:

Ci.nsIWebProgress.NOTIFY_STATE_NETWORK | Ci.nsIWebProgress.NOTIFY_LOCATION;

And this is what we get:

onStateChange: isTopLevel=true, flags=0xf0001, status=NS_OK uri=https://www.google.com/search?q=what
onStateChange: isTopLevel=true, flags=0xf0001, status=NS_OK uri=https://www.google.com/search?q=what
onStateChange: isTopLevel=true, flags=0xc0010, status=NS_OK uri=https://www.google.com/search?q=what

Note the duplicate 0xf0001 event. This corresponds to the following:

STATE_START | STATE_IS_REQUEST | STATE_IS_DOCUMENT | STATE_IS_NETWORK | STATE_IS_WINDOW

This is what we would normally expect:

onStateChange: isTopLevel=true, flags=0xf0001, status=NS_OK uri=https://www.google.com/search?q=what
onStateChange: isTopLevel=true, flags=0xc0010, status=NS_OK uri=https://www.google.com/search?q=what

We plan to land a workaround for this in Bug 1672262.

Flags: needinfo?(agakhokidze)

Might be fixed by bug 1661833. Agi, can you check if this is still an issue?

Flags: needinfo?(agakhokidze) → needinfo?(agi)

Looks like this is fixed!

Flags: needinfo?(agi)

I'll morph this bug to remove the workaround.

Component: DOM: Navigation → General
Product: Core → GeckoView
Summary: Duplicate STATE_START events when switching process → Remove workaround for duplicate STATE_START events when switching process

It looks like the patch landed in the wrong bug 1672262 instead. https://hg.mozilla.org/mozilla-central/rev/79aca2b9e53a

Flags: needinfo?(agi)

Ouch. Sorry about that.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(agi)
Resolution: --- → FIXED
status-firefox85: --- → fixed
You need to log in before you can comment on or make changes to this bug.