1672464 - Block WebRender for NVIDIA users with mixed refresh rates

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P1)

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1672464 - Block WebRender for NVIDIA users with mixed refresh rates.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3476de962c82
Block WebRender for NVIDIA users with mixed refresh rates. r=jrmuizel

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3476de962c82

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9183252 [details]
Bug 1672464 - Block WebRender for NVIDIA users with mixed refresh rates.

Beta/Release Uplift Approval Request

• User impact if declined: Some NVIDIA users will get WebRender and experience issues due to mixed high refresh rate displays.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Currently we are shipping WebRender to all NVIDIA users, at least relative to refresh rate. We just want to turn it off for a relatively small population due to existing issues. It hasn't been verified in nightly because this code path is only active in beta/release, but we do have automated tests written for it.
• String changes made/needed:

Comment 5

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9183252 [details]
Bug 1672464 - Block WebRender for NVIDIA users with mixed refresh rates.

Approved for 83 beta 5, thanks.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This has conflicts caused by bug 1671518. Please attach a rebased patch.

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Rebased on top of latest beta, v1

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

try with rebased patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fec0f8395f400b34a4269c704a062dbb2a2d2620

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/69c189f93184

Comment 10

[Ryan VanderMeulen [:RyanVM]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #9)

https://hg.mozilla.org/releases/mozilla-beta/rev/69c189f93184

Note that this missed the b5 build and will be in b6 instead.