flowmap stores list of items for each hash, but only the most recent one is used.
Categories
(Testing :: Raptor, enhancement, P1)
Tracking
(firefox84 fixed)
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: kanishk509, Assigned: kanishk509)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.111 Safari/537.36
Expected results:
In alternate-server-replay.py (https://searchfox.org/mozilla-central/source/testing/mozbase/mozproxy/mozproxy/backends/mitm/scripts/alternate-server-replay.py), flowmap stores a list of items which have the same colliding hash, but only the most recent item is ever used, so storing the full list seems unnecessary.
According to :bebe,
That code supported multiple changes over time according to the proxy version and usage.
He suggested I file a bug report for review of the code.
|
||
Comment 1•4 years ago
|
||
Looks good to me. can you make a patch for this change please
|
||
Updated•4 years ago
|
Submitted a patch.
Try job for amazon and amazon-c.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2330aaca6458390780ca9b1beadb3ff83c01361b
|
||
Updated•4 years ago
|
Pushed by fstrugariu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66f7d948b271 Store only most recent flow in flowmap for a particular hash. r=Bebe,perftest-reviewers
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Description
•