Closed Bug 1672486 Opened 1 year ago Closed 2 months ago

Remove browser.toolbars.bookmarks.2h2020 pref and the dead code when the pref is always true

Categories

(Firefox :: Bookmarks & History, task, P3)

task
Points:
1

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: jaws, Assigned: mkohler)

References

(Blocks 3 open bugs)

Details

Attachments

(4 files)

Bug 1665353 tracks some changes we are making to bookmarks in Firefox. Part of that work introduced a pref named "browser.toolbars.bookmarks.2h2020" which is used for experimentation and gating of the feature work.

After we have concluded experimentation, we should remove the preference and the then-dead code that will result from the decision of which behavior to use going forward.

Blocks: 1412263

I would love to take this issue, although I may need some guidance along the way as it will be my first issue related to firefox desktop.

Flags: needinfo?(jaws)

I don't know if we are ready to remove this pref yet. We are still gathering data to determine the effects of this change. We should have those results in a couple weeks.

Flags: needinfo?(jaws)

Hey jaws,

browser.toolbars.bookmarks.2h2020 has been set to true for a number of months now... can we presume this is where we want to keep it, and can remove the pref and its false branches?

Flags: needinfo?(jaws)
Depends on: 1719907

(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)

Hey jaws,

browser.toolbars.bookmarks.2h2020 has been set to true for a number of months now... can we presume this is where we want to keep it, and can remove the pref and its false branches?

Yes, it should be safe to remove the pref now.

Flags: needinfo?(jaws)
Assignee: nobody → me
Points: --- → 1
Status: NEW → ASSIGNED
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/e412f90c3aeb
Remove browser.toolbars.bookmarks.2h2020 pref from browser/customizableui/places r=mak
https://hg.mozilla.org/integration/autoland/rev/ec76ea1a53cb
Remove browser.toolbars.bookmarks.2h2020 pref in policies r=mak
https://hg.mozilla.org/integration/autoland/rev/6981831be52e
Remove browser.toolbars.bookmarks.2h2020 pref in migration r=mak
https://hg.mozilla.org/integration/autoland/rev/ab41490c55e0
Remove browser.toolbars.bookmarks.2h2020 pref from firefox.js r=mak,Gijs
You need to log in before you can comment on or make changes to this bug.