1672486 - Remove browser.toolbars.bookmarks.2h2020 pref and the dead code when the pref is always true

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1665353 tracks some changes we are making to bookmarks in Firefox. Part of that work introduced a pref named "browser.toolbars.bookmarks.2h2020" which is used for experimentation and gating of the feature work.

After we have concluded experimentation, we should remove the preference and the then-dead code that will result from the decision of which behavior to use going forward.

Comment 1

[Ankush Dua]

I would love to take this issue, although I may need some guidance along the way as it will be my first issue related to firefox desktop.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I don't know if we are ready to remove this pref yet. We are still gathering data to determine the effects of this change. We should have those results in a couple weeks.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hey jaws,

browser.toolbars.bookmarks.2h2020 has been set to true for a number of months now... can we presume this is where we want to keep it, and can remove the pref and its false branches?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)

Hey jaws,

browser.toolbars.bookmarks.2h2020 has been set to true for a number of months now... can we presume this is where we want to keep it, and can remove the pref and its false branches?

Yes, it should be safe to remove the pref now.

Comment 5

[Michael Kohler [:mkohler]]

Attachment: Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from browser/customizableui/places r?mak

Comment 6

[Michael Kohler [:mkohler]]

Attachment: Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref in policies r?mak

Depends on D127588

Comment 7

[Michael Kohler [:mkohler]]

Attachment: Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref in migration r?mak

Depends on D127589

Comment 8

[Michael Kohler [:mkohler]]

Attachment: Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from firefox.js r?mak

Depends on D127590

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e412f90c3aeb
Remove browser.toolbars.bookmarks.2h2020 pref from browser/customizableui/places r=mak
https://hg.mozilla.org/integration/autoland/rev/ec76ea1a53cb
Remove browser.toolbars.bookmarks.2h2020 pref in policies r=mak
https://hg.mozilla.org/integration/autoland/rev/6981831be52e
Remove browser.toolbars.bookmarks.2h2020 pref in migration r=mak
https://hg.mozilla.org/integration/autoland/rev/ab41490c55e0
Remove browser.toolbars.bookmarks.2h2020 pref from firefox.js r=mak,Gijs

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e412f90c3aeb
https://hg.mozilla.org/mozilla-central/rev/ec76ea1a53cb
https://hg.mozilla.org/mozilla-central/rev/6981831be52e
https://hg.mozilla.org/mozilla-central/rev/ab41490c55e0