Closed Bug 1672539 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26117 - blink: makes LayoutBox honor overflow-clip-margin

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26117 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26117
Details from upstream follow.

b'Scott Violet <sky@chromium.org>' wrote:

blink: makes LayoutBox honor overflow-clip-margin

This does the following:

If overflow-clip-margin changes, then need to repaint

OverflowClipRect() and VisualOverflowRect() adjust for
overflow-clip-margin (overflow-clip-margin is only set if overflow:clip
is set along both axis).

BUG=1087667
TEST=wpt/css/css-overflow/overflow-clip-margin-invalidation
wpt/css/css-overflow/overflow-clip-margin-001.html

Change-Id: I9875c724c153600bf8eafe633bc138d99de3099a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468794
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Xianzhu Wang \<wangxianzhu@chromium.org>
Commit-Queue: Scott Violet \<sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819170}

Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 1
FAIL: 3

Chrome

PASS: 1
FAIL: 3

Safari

PASS: 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-overflow/overflow-clip-margin-001.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-overflow/overflow-clip-margin-002.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-overflow/overflow-clip-margin-invalidation.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ebe08df825f2
[wpt PR 26117] - blink: makes LayoutBox honor overflow-clip-margin, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4fba052af17f
[wpt PR 26117] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.