Closed Bug 1672551 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26183 - webdriver: handle events with Unidentified key code

Categories

(Testing :: geckodriver, task, P4)

Product:
Testing
Component:
geckodriver
Type:
task

Tracking

(firefox84 fixed)

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26183 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26183
Details from upstream follow.

b'Carlos Garcia Campos <cgarcia@igalia.com>' wrote:

webdriver: handle events with Unidentified key code

WebKit sets the event key code as Unidentified as per the spec (see
https://www.w3.org/TR/uievents-code/), but WebDriver tests expect an
empty string for the case of unidentified key codes. This patch changes
the code to an empty string when Unidentified is found.

Component: web-platform-tests → geckodriver

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 17 tests and 6 subtests

Status Summary

Firefox

OK : 17
PASS: 181
FAIL: 24

Chrome

OK : 17
PASS: 195
FAIL: 10

Safari

OK : 17
PASS: 142
FAIL: 63

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/webdriver/tests/perform_actions/key_events.py
test_modifier_key_sends_correct_events[\ue03d-META]: FAIL
test_special_key_sends_keydown[ADD-expected0]: FAIL
test_special_key_sends_keydown[META-expected30]: FAIL
test_special_key_sends_keydown[NUMPAD4-expected37]: FAIL
test_special_key_sends_keydown[NUMPAD5-expected38]: FAIL
test_special_key_sends_keydown[PAGE_DOWN-expected43]: FAIL
test_special_key_sends_keydown[PAGE_UP-expected44]: FAIL
test_special_key_sends_keydown[SUBTRACT-expected66]: FAIL
/webdriver/tests/perform_actions/validity.py
test_pause_positive_integer[none]: FAIL
test_pause_positive_integer[key]: FAIL
test_pause_positive_integer[pointer]: FAIL
/webdriver/tests/perform_actions/wheel.py
test_no_top_browsing_context: FAIL
test_no_browsing_context: FAIL

New Tests That Don't Pass

/webdriver/tests/perform_actions/key_events.py
test_modifier_key_sends_correct_events[\ue03d-META]: FAIL (Chrome: PASS, Safari: PASS)
test_modifier_key_sends_correct_events[\ue053-R_META]: FAIL (Chrome: PASS, Safari: FAIL)
test_special_key_sends_keydown[ADD-expected0]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[META-expected30]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[NUMPAD4-expected37]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[NUMPAD5-expected38]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[PAGE_DOWN-expected43]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[PAGE_UP-expected44]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[R_META-expected58]: FAIL (Chrome: PASS, Safari: FAIL)
test_special_key_sends_keydown[SEPARATOR-expected63]: FAIL (Chrome: PASS, Safari: FAIL)
test_special_key_sends_keydown[SUBTRACT-expected66]: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/perform_actions/pointer.py
test_drag_and_drop_with_draggable_element[0]: FAIL (Chrome: FAIL, Safari: FAIL)
test_drag_and_drop_with_draggable_element[300]: FAIL (Chrome: FAIL, Safari: FAIL)
test_drag_and_drop_with_draggable_element[800]: FAIL (Chrome: FAIL, Safari: FAIL)
/webdriver/tests/perform_actions/pointer_tripleclick.py
test_tripleclick_at_coordinates: FAIL (Chrome: PASS, Safari: FAIL)
/webdriver/tests/perform_actions/validity.py
test_pause_positive_integer[none]: FAIL (Chrome: PASS, Safari: PASS)
test_pause_positive_integer[key]: FAIL (Chrome: PASS, Safari: PASS)
test_pause_positive_integer[pointer]: FAIL (Chrome: PASS, Safari: PASS)
/webdriver/tests/perform_actions/wheel.py
test_null_response_value: FAIL (Chrome: PASS, Safari: FAIL)
test_no_top_browsing_context: FAIL (Chrome: PASS, Safari: PASS)
test_no_browsing_context: FAIL (Chrome: PASS, Safari: PASS)
test_wheel_scroll: FAIL (Chrome: PASS, Safari: FAIL)
test_wheel_scroll_overflow: FAIL (Chrome: PASS, Safari: FAIL)
test_wheel_scroll_iframe: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb9ecd065d6a
[wpt PR 26183] - webdriver: handle events with Unidentified key code, a=testonly

https://hg.mozilla.org/mozilla-central/rev/cb9ecd065d6a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.