Closed Bug 1672634 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26229 - Fix line cache when `-webkit-line-clamp` is specified

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

Product:
Core
Component:
Layout: Scrolling and Overflow
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26229 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26229
Details from upstream follow.

b'Koji Ishii <kojii@chromium.org>' wrote:

Fix line cache when -webkit-line-clamp is specified

|NGBlockLayoutAlgorithm| has two branches, one when
|lines_until_clamp_| becomes |\<= 0| by the layout, and another
when it is |== 0|.

To make sure we run all these logic, this patch:

  • Updates |lines_until_clamp_| by the number of reused lines.
  • Limits reusing only up to 1, so that conditions above go
    normal layout codepath.

Bug: 1140951
Change-Id: I15fe81b4957fe70d23bb88aae700642297bb1550

Reviewed-on: https://chromium-review.googlesource.com/2491561
WPT-Export-Revision: 4455b386514d66c90734567571108393f639904c

Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98107d0a1fe2
[wpt PR 26229] - Fix line cache when `-webkit-line-clamp` is specified, a=testonly

https://hg.mozilla.org/mozilla-central/rev/98107d0a1fe2

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.