1672660 - Intermittent devtools/shared/resources/tests/browser_browser_resources_console_messages.js | leaked 1 docShell(s) until shutdown

Status: RESOLVED FIXED

(DevTools :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=319349193&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/OfSzWVwcSYGgHmLLSfItIg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/OfSzWVwcSYGgHmLLSfItIg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2020-10-22T11:19:02.907Z] 11:19:02     INFO - TEST-START | devtools/shared/resources/tests/browser_browser_resources_console_messages.js
[task 2020-10-22T11:19:21.882Z] 11:19:21     INFO - TEST-INFO | Confirming we saw 43 DOMWINDOW created and 43 destroyed log strings.
[task 2020-10-22T11:19:21.882Z] 11:19:21    ERROR - TEST-UNEXPECTED-FAIL | devtools/shared/resources/tests/browser_browser_resources_console_messages.js | leaked 1 docShell(s) until shutdown
[task 2020-10-22T11:19:21.882Z] 11:19:21     INFO - TEST-INFO | devtools/shared/resources/tests/browser_browser_resources_console_messages.js | docShell(s) leaked: [pid = 26056] [id = 1]
[task 2020-10-22T11:19:21.882Z] 11:19:21     INFO - TEST-INFO | devtools/shared/resources/tests/browser_browser_resources_console_messages.js | This test created 1 hidden window(s)
[task 2020-10-22T11:19:21.882Z] 11:19:21     INFO - TEST-INFO | devtools/shared/resources/tests/browser_browser_resources_console_messages.js | This test created 1 hidden docshell(s)
[task 2020-10-22T11:19:21.883Z] 11:19:21     INFO - runtests.py | Application ran for: 0:00:27.857436
[task 2020-10-22T11:19:21.883Z] 11:19:21     INFO - zombiecheck | Reading PID log: /tmp/tmp_KKOMVpidlog
[task 2020-10-22T11:19:21.883Z] 11:19:21     INFO - ==> process 25905 launched child process 25926
[task 2020-10-22T11:19:21.884Z] 11:19:21     INFO - ==> process 25905 launched child process 26056
[task 2020-10-22T11:19:21.884Z] 11:19:21     INFO - ==> process 25905 launched child process 26079
[task 2020-10-22T11:19:21.885Z] 11:19:21     INFO - ==> process 25905 launched child process 26136
[task 2020-10-22T11:19:21.886Z] 11:19:21     INFO - ==> process 25905 launched child process 26165
[task 2020-10-22T11:19:21.888Z] 11:19:21     INFO - ==> process 25905 launched child process 26225
[task 2020-10-22T11:19:21.889Z] 11:19:21     INFO - zombiecheck | Checking for orphan process with PID: 25926
[task 2020-10-22T11:19:21.890Z] 11:19:21     INFO - zombiecheck | Checking for orphan process with PID: 26056
[task 2020-10-22T11:19:21.891Z] 11:19:21     INFO - zombiecheck | Checking for orphan process with PID: 26225
[task 2020-10-22T11:19:21.892Z] 11:19:21     INFO - zombiecheck | Checking for orphan process with PID: 26165
[task 2020-10-22T11:19:21.893Z] 11:19:21     INFO - zombiecheck | Checking for orphan process with PID: 26136
[task 2020-10-22T11:19:21.895Z] 11:19:21     INFO - zombiecheck | Checking for orphan process with PID: 26079
[task 2020-10-22T11:19:21.896Z] 11:19:21     INFO - Stopping web server
[task 2020-10-22T11:19:21.897Z] 11:19:21     INFO - Stopping web socket server
[task 2020-10-22T11:19:21.918Z] 11:19:21     INFO - Stopping ssltunnel```

Comment 1

[Razvan Maries]

Tier 1 failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319361909&repo=autoland&lineNumber=15547

Alexandre, could you take a look?

Comment 2

[Alexandre Poirot [:ochameau]]

On it. It seems easy to reproduce locally, surprising this isn't a permafail.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1672660 - [devtools] Unregister docshell listeners only if we had time to register them.

It looks like we are destroying the target actor immediately, without having time
to call _watchDocshells. And given that removeObserver throws if there is no matching listener
already registered, it prevent detaching the target correctly, and, introduces a leak.

Comment 4

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Beta milestone (M7).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/673c29179104
[devtools] Unregister docshell listeners only if we had time to register them. r=nchevobbe

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/673c29179104

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1620248

Comment 8

[Intermittent Failures Robot]

3 failures in 4230 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3

Platform breakdown:

• linux1804-64: 2
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1672660&startday=2020-10-19&endday=2020-10-25&tree=all