1672730 - Firefox Developer Edition keyboard shortcut for Bookmarks (Library) is incorrect

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect, P2)

Description

[jamie]

Attachment: Screen Shot 2020-10-21 at 11.26.11 AM.png

This is specific to the Developer Edition of Firefox.

According to your docs the shortcut to open The Library window for Bookmarks should be command + shift + B but it's opening on command + shift + O

I have another keyboard shortcut tied to command + shift + O that I and my coworkers use constantly, and it's very frustrating that the Library window started opening on the latest release. One of my co-workers switched to regular Firefox browser because of this.

Comment 1

[:Gijs (he/him)]

On what OS are you testing, which exact version of developer edition are you using and do you have updates available? What's the value of browser.toolbars.bookmarks.2h2020 in about:config ?

The changes from bug 1328637 should have been disabled on beta in bug 1671952.

Comment 2

[jamie]

OS: Catalina
Version: 83.0b2
No updates available

The value is false for browser.toolbars.bookmarks.2h2020

Comment 3

[:Gijs (he/him)]

Hm, maybe I understand - does command+shift+b open the library? The issue for you is just that command+shift+o also opens the library?

Comment 4

[jamie]

Attachment: Screen Shot 2020-10-22 at 11.47.19 AM.png

Comment 5

[jamie]

Confirming cmd + shift + B also opens the Library.

Comment 6

[Alice0775 White]

(In reply to :Gijs (he/him) from comment #3)

Hm, maybe I understand - does command+shift+b open the library? The issue for you is just that command+shift+o also opens the library?

I can reproduce the issue on 83.0b2 Windows10.
Ctrl+Shift+O opens the Library as well as Ctrl+Shift+B.

Comment 7

[Alice0775 White]

Attachment: image.png

And menu also indicates Ctrl+Shift+O...

Comment 8

[:Gijs (he/him)]

Jared/Micah: is this expected, given the pref is turned off?

Comment 9

[Micah [:mtigley] (she/her)]

(In reply to :Gijs (he/him) from comment #8)

Jared/Micah: is this expected, given the pref is turned off?

The menu should still show Ctrl + Shift + B if the pref is turned off. After talking about this with Jared, maybe we can add the command element dynamically if the pref is set to true.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1328637

Comment 11

[:Gijs (he/him)]

Thanks Micah for picking this up!

(In reply to jamie from comment #0)

According to your docs the shortcut to open The Library window for Bookmarks should be command + shift + B but it's opening on command + shift + O

I have another keyboard shortcut tied to command + shift + O that I and my coworkers use constantly, and it's very frustrating that the Library window started opening on the latest release. One of my co-workers switched to regular Firefox browser because of this.

So, we'll be trying to fix this regression for beta/devedition for the 83 release. But the reason this is happening at all is that in bug 1328637 we're adding a shortcut for toggling the bookmarks toolbar, which will be command + shift + B, and in order to still have a shortcut for the library still, we're using command + shift + O. We used that shortcut as it's already the library shortcut on Linux (for historical reasons). We currently expect that change to go out with Firefox 84.

Can you elaborate on what you use command + shift + O for, and how that use is affected by our choice here? We can show the "right" shortcut in the menu and avoid adding the new one for another release, and that will help you and your co-worker for an extra month or so. But once 84 hits devedition/beta (and, a month later, release), the menu will show command + shift + O and we will update the documentation to indicate that, and to show that command + shift + B will toggle the bookmarks toolbar's visibility -- and, by the sounds of it, that would break something (unsure what) for you and your co-workers?

Comment 12

[jamie]

Appreciate the explanation and noted on command + shift + O being used in the upcoming release. In that case, it makes more sense for me to submit a ticket with my company to change our shortcut to something that's not being used by Firefox/Chrome. We use command + shift + O to search our custom CMS, so obviously, this is an issue unique to our company. We use the shortcut constantly during the workday so its a real blocker unfortunately. I happen to notice this shortcut didn't match your docs so thought it might be a bug worth reporting.

On the flip side, this is something we can easily change, so we'll resolve the issue on our end. Thanks for looking into this so quickly and being so responsive!

Best,

Jamie

Comment 13

[:Gijs (he/him)]

(In reply to jamie from comment #12)

I happen to notice this shortcut didn't match your docs so thought it might be a bug worth reporting.

Thanks!

We use command + shift + O to search our custom CMS, so obviously, this is an issue unique to our company. We use the shortcut constantly during the workday so its a real blocker unfortunately.

FWIW, because this shortcut is not what we call "reserved", websites can override it, if focus is in the webpage and the webpage calls event.preventDefault(), I think that should be sufficient to stop the library window opening. You can try e.g. https://bug1052569.bmoattachments.org/attachment.cgi?id=8471708 , which is the testcase for bug 1052569 and has some background: we added e.g. window/tab-closing shortcuts as "reserved" because we don't want websites to block those core features. But the library ones aren't reserved.

Comment 14

[jamie]

Thanks for this. I put a ticket in with my team to do the override. If we run into any issues I'll let you know.

Comment 15

[Micah [:mtigley] (she/her)]

Attachment: Bug 1672730 - Show correct shortcut key for Show All Bookmarks menu item

Comment 16

[Micah [:mtigley] (she/her)]

This issue is resolved by the work in Bug 1675549

Comment 17

[Mathew Hodson]

The change from bug 1328637 was backed out with https://hg.mozilla.org/releases/mozilla-release/rev/b4d233ef14ae

So this should be fixed in a new build of Firefox 83