1672763 - Telemetry for new Logged Out Save

Status: RESOLVED FIXED

(Firefox :: Pocket, enhancement, P1)

Description

[Gavin Suntop [:gvn] (they/them)]

Per Kirill:

This ping sends two types of events: click and disable. The former is for clicks of the Pocket button or any UI elements in the door hanger. The latter is for disabling the Pocket button entirely via the context menu.

Click events can have a source of any of the following:

      "enum": [
        "save_button",
        "learn_more",
        "log_in",
        "sign_up_1",
        "sign_up_2"
      ],

…which should be enough to capture clicks of the Pocket button and clicks of any UI elements in these mockups.

A few notes:
-sign_up_1 vs. _2 is for the control variant, which has two sign up buttons. Other variants can use just sign_up_1 .
-Disable events can have a source of save_button to avoid having to add another case here.

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Telemetry spec is in the PRD: https://docs.google.com/document/d/11S3LFYoCaPBRaCeE4ErLca22OgNcXfKPXAe2ECfAjrY/edit

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 1672763 - Telemetry for Pocket button.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/638

Comment 4

[Scott [:thecount] Downe]

To test:

Prerequisite:

1. Create a new profile
2. Set browser.ping-centre.log to true
3. Ensure you can see the multi process debugger console.
4. Make sure you're logged out of Pocket.

Logged out doorhanger buttons.

1. Open the Pocket door hanger from a normal url.
2. Click on each of these links. learn more, log in, singup with firefox, signup with email

Expected: you should see a telemetry ping with action click for each button, with a source key that matched the button you clicked.

Main Pocket button

1. Open the Pocket door hanger from a normal url

Expected: you should see a telemetry ping with action click and a source "save_button"

Unpin

1. Right click the save to Pocket button
2. Click "remove from address bar"

Expected: you should see a telemetry ping with action unpin and source "save_button"

Comment 5

[Kirill Demtchouk]

Attachment: request.txt

Attaching Data Collection request for Kenny to review.

Comment 6

[klong]

Comment on attachment 9187488 [details]
request.txt

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

The schema for this ping can be found here:
https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/638

Scott Downe has added public documentation as part of this PR, but it is not yet merged:
https://phabricator.services.mozilla.com/D96603#change-VOgphsgFNuKi

It will eventually live here:
https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/v2-system-addon/data_events.html#

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. Users can opt-out the data collection by disabling the Firefox telemetry.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Kirill Demtchouk ([e-mail]) will be monitoring those metrics.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

This classified this as Category 2. It tracks clicks/impressions of content recommendations, but it does not identify the content that was viewed/clicked. It also tracks clicks on the Pocket button in general.

Is the data collection request for default-on or default-off?

Default on for all channels and countries/locales.

Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

Does the data collection use a third-party collection tool?

No.

---

Result: r+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d02a4568f89
Telemetry for Pocket button. r=gvn

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2d02a4568f89