1672765 - [wpt-sync] Sync PR 26209 - Reland "[Longtasks] Fix buffering before observer"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 26209 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26209
Details from upstream follow.

b'Nicol\xc3\xa1s Pe\xc3\xb1a Moreno <[e-mail]>' wrote:

Reland "[Longtasks] Fix buffering before observer"

This is a reland of c2d62d3604e218cfd1b62877684c634980aea3f7. This is
safe to reland because it got reverted due to the issue that has been
fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=1108676.

Original change's description:

[Longtasks] Fix buffering before observer

When we shipped longtasks with buffered flag, we forgot to remove a
check that would prevent longtask creation when there's no observer.
This CL fixes this and adds a test for this case. It also moves the
UseCounter to the observe() method.

Bug: 1131385
Change-Id: I2911b9ab044db7394bcf64f64b1e599959cbdc37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463594
Reviewed-by: Steve Kobes \<[e-mail]>
Commit-Queue: Nicolás Peña Moreno \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#816664}

Bug: 1131385
Change-Id: I8640abc566fc7eceaf44e80c04d23ca59182542d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491100
Reviewed-by: Steve Kobes \<[e-mail]>
Commit-Queue: Nicolás Peña Moreno \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#819832}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd60aced3b1d11558dfc1d8e2a303e13000ae36f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/longtask-timing/longtask-before-observer.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
PerformanceObserver with buffered flag can see previous longtask entries.: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/longtask-timing/longtask-before-observer.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4378c7d858c7
[wpt PR 26209] - Reland "[Longtasks] Fix buffering before observer", a=testonly

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4378c7d858c7