1672776 - Crash in [@ mozilla::a11y::GeckoTextMarker::CreateAXTextMarker]

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

Crash report: https://crash-stats.mozilla.org/report/index/53d05233-9297-4c7d-812b-29c600201022

Reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS

Top 10 frames of crashing thread:

0 XUL mozilla::a11y::GeckoTextMarker::CreateAXTextMarker accessible/mac/GeckoTextMarker.mm:128
1 XUL -[MOXTextMarkerDelegate moxRightWordTextMarkerRangeForTextMarker:] accessible/mac/MOXTextMarkerDelegate.mm:167
2 XUL -[MOXAccessibleBase accessibilityAttributeValue:forParameter:] accessible/mac/MOXAccessibleBase.mm:348
3 AppKit ___NSAccessibilityEntryPointValueForAttributeWithParameter_block_invoke.821 
4 AppKit NSAccessibilityPerformEntryPointObject 
5 AppKit NSAccessibilityEntryPointValueForAttributeWithParameter 
6 AppKit CopyParameterizedAttributeValue 
7 HIServices _AXXMIGCopyParameterizedAttributeValue 
8 HIServices _XCopyParameterizedAttributeValue 
9 HIServices mshMIGPerform 

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1672776 - Return nil TextMarker(Range) if GeckoTextMarker(Range) is invalid. r?morgan!

It seems like the GeckoTextMarker::Range can sometimes return invalid ranges.
We need to check if they are valid or not before marshalling them.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ce2731941fe
Return nil TextMarker(Range) if GeckoTextMarker(Range) is invalid. r=morgan

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7ce2731941fe

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:eeejay, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.