1672836 - The NumDrawCalls marker has stopped working, always reports 0

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Markus Stange [:mstange]]

This broke some time in the last two days.

Steps to reproduce:

1. Have WebRender enabled.
2. In the Firefox profiler settings, make sure the Renderer thread is getting profiled.
3. Start the profiler.
4. Use the browser in such a way that WebRender has things to render.
5. Grab a profile.
6. Select the "Renderer" thread and look at the NumDrawCalls markers.

Expected results:
The numbers should be reasonable.

Actual results:
All numbers are zero.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1672836 - Read the profile counters before handing them to the profiler. r=mstange

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/708f828e1673
Read the profile counters before handing them to the profiler. r=mstange

Comment 3

[Peter Magyari (Desktop QA)]

Hi Markus,

I'm having trouble reproducing your issue using the latest Firefox Nightly 84.0a1 (2020-10-26) on Mac 10.15

Could you please run a Mozregression in order to get a pushlog which shows when this issue was introduced?
Here is the tool you will need to use in order to do this: https://mozilla.github.io/mozregression/
This way we can find out what introduced the issue, since you've mentioned that you did not have this problem 5-6 days ago.

Thanks!

Comment 4

[Markus Stange [:mstange]]

Sorry, forgot to remove regressionwindow-wanted. We know what caused it and the fix has already landed.

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/708f828e1673

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1672216