Closed Bug 1672879 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26245 - Trying to improve selection-contenteditable-011.html and its reference

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26245 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26245
Details from upstream follow.

b'G\xc3\xa9rard Talbot <github@gtalbot.org>' wrote:

Trying to improve selection-contenteditable-011.html and its reference

This is a followup to
https://github.com/web-platform-tests/wpt/pull/25642

selection-contenteditable-011.html
reference/selection-contenteditable-011-ref.html

As discussed in
https://github.com/web-platform-tests/wpt/pull/25642#pullrequestreview-499076577
it may be better to focus() the contenteditable element in the reference file instead... which we are doing in this PR.

I had to add
document.getElementById("test").style.caretColor = "yellow";
to work around a side effect of focus-ing a contenteditable element in Firefox.

Browsers (Chromium, Firefox, Safari) do not behave exactly the same when select()-ing a contenteditable element (and text input and textarea element).

We hope to flatten, to smooth out these differences with the added code of the current PR.

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/selection-contenteditable-011.html: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36c9f4144667
[wpt PR 26245] - Trying to improve selection-contenteditable-011.html and its reference, a=testonly
https://hg.mozilla.org/integration/autoland/rev/aa5d2d5b9a0b
[wpt PR 26245] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.