Closed Bug 1672892 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26193 - HTMLPluginElement: Add object to frame view's update part if locked.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26193 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26193
Details from upstream follow.

b'Vladimir Levin <vmpstr@chromium.org>' wrote:

HTMLPluginElement: Add object to frame view's update part if locked.

This patch ensures that when we delay the load because the plugins
need to be loaded and we're under a content-visibility lock, then
we add the object to be updated into frame view's list immediately

This is typically done during layout, but if layout is prevented then
we run into a possibility of delaying load event forever. Adding
the object to the update set immediately avoids the problem.

R=masonfreed@chromium.org

Bug: 1138128
Change-Id: I4d918c6bbdcd80aa6f01bf3b068acb64a93b0196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485671
Commit-Queue: vmpstr \<vmpstr@chromium.org>
Reviewed-by: Mason Freed \<masonfreed@chromium.org>
Reviewed-by: Stefan Zager \<szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820068}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS : 1

Chrome

TIMEOUT: 2

Safari

OK : 1
PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d8c7f97ad2b
[wpt PR 26193] - HTMLPluginElement: Add object to frame view's update part if locked., a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.