Closed
Bug 1672909
Opened 5 years ago
Closed 5 years ago
Wrong height for buttons inside notification bars
Categories
(Thunderbird :: Theme, defect)
Thunderbird
Theme
Tracking
(thunderbird_esr78 unaffected)
RESOLVED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
People
(Reporter: aleca, Assigned: Paenglab)
Details
(Keywords: regression)
Attachments
(2 files)
|
12.50 KB,
image/png
|
Details | |
|
1.58 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
Screen Shot 2020-10-22 at 9.19.36 PM.png
I started noticing today that the buttons inside a notification bar are squished and don't span for their correct height.
The easiest one to spot is when triggering the attachment reminder notification in the compose window.
This is probably a regression from toolkit.
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
We need a fixed height of 24px. Additionally fixed the spacing for the Windows dropmarker in notification buttons.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9183462 -
Flags: review?(alessandro)
|
|
Reporter | |
Comment 2•5 years ago
|
||
Comment on attachment 9183462 [details] [diff] [review]
1672909-notification-button-height.patch
Review of attachment 9183462 [details] [diff] [review]:
-----------------------------------------------------------------
Great, thanks!
Attachment #9183462 -
Flags: review?(alessandro) → review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed-tb
Target Milestone: --- → 84 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/fd006ccf1d62
Fix the notification button height. r=aleca DONTBUILD
You need to log in
before you can comment on or make changes to this bug.
Description
•