1672931 - Crash in [@ mozilla::fontlist::FontList::FindFamily]

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Crash report: https://crash-stats.mozilla.org/report/index/ed3c9432-f90b-4522-8efd-9bdd90201023

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll mozilla::fontlist::FontList::FindFamily gfx/thebes/SharedFontList.cpp:924
1 xul.dll gfxDWriteFontList::GetDirectWriteSubstitutes gfx/thebes/gfxDWriteFontList.cpp:1812
2 xul.dll gfxDWriteFontList::InitSharedFontListForPlatform gfx/thebes/gfxDWriteFontList.cpp:1434
3 xul.dll gfxPlatformFontList::InitFontList gfx/thebes/gfxPlatformFontList.cpp:497
4 xul.dll gfxWindowsPlatform::CreatePlatformFontList gfx/thebes/gfxWindowsPlatform.cpp:569
5 xul.dll static gfxPlatform::Init gfx/thebes/gfxPlatform.cpp:991
6 xul.dll static gfxPlatform::InitChild gfx/thebes/gfxPlatform.cpp:525
7 xul.dll mozilla::dom::ContentChild::RecvSetXPCOMProcessAttributes dom/ipc/ContentChild.cpp:628
8 xul.dll mozilla::dom::PContentChild::OnMessageReceived ipc/ipdl/PContentChild.cpp:11306
9 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2074

Comment 1

[Jonathan Kew [:jfkthame]]

Ah, I see how this could happen: if the parent process failed to initialize the shared list for any reason, and falls back to an in-process font list, then content processes will crash here because GetDirectWriteSubstitutes (and GetFontSubstitutes, which follows) will attempt family-name lookups, but the list isn't valid. So we should bail out before calling those functions, as the content process is also going to have to fall back to a non-shared list anyway.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1672931 - Bail out of InitSharedFontListForPlatform before attempting to look up substitutions, if we failed to initialize the list at all. r=lsalzman

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd8ad0c23114
Bail out of InitSharedFontListForPlatform before attempting to look up substitutions, if we failed to initialize the list at all. r=lsalzman

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/dd8ad0c23114

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jfkthame, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Jonathan Kew [:jfkthame]]

This is preffed-off by default from late-beta onwards, so probably not important to uplift at this point.