Closed Bug 1672938 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26251 - Add StreamPipeOptions to Readable Streams

Categories

(Core :: JavaScript Engine, task, P4)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26251 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26251
Details from upstream follow.

b'Nidhi Jaju <nidhijaju@google.com>' wrote:

Add StreamPipeOptions to Readable Streams

In an effort to change the blink implementation of readable
streams to better match the Web IDL descriptions in the Streams
API Standard, this CL adds the StreamPipeOptions dictionary [1]
to the ReadableStream class.

[1] https://streams.spec.whatwg.org/#dictdef-streampipeoptions

Bug: 1093862
Change-Id: Ic03fff0d645786dd48c4d8b7cd8682e0442bff0a
Reviewed-on: https://chromium-review.googlesource.com/2488329
WPT-Export-Revision: d28924d6e0d2ec3c55b496946725c4424c48ad8a

Component: web-platform-tests → JavaScript Engine
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 14 subtests

Status Summary

Firefox

OK : 4
FAIL : 56

Chrome

OK : 4
PASS : 52
FAIL : 4

Safari

OK : 3
PASS : 39
FAIL : 3
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/streams/piping/general.any.serviceworker.html
Piping must lock both the ReadableStream and WritableStream: FAIL
Piping finishing must unlock both the ReadableStream and WritableStream: FAIL
pipeTo must check the brand of its ReadableStream this value: FAIL
pipeTo must check the brand of its WritableStream argument: FAIL
pipeTo must fail if the ReadableStream is locked, and not lock the WritableStream: FAIL
pipeTo must fail if the WritableStream is locked, and not lock the ReadableStream: FAIL
Piping from a ReadableStream from which lots of chunks are synchronously readable: FAIL
Piping from a ReadableStream for which a chunk becomes asynchronously readable after the pipeTo: FAIL
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is true: FAIL
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is false: FAIL
an undefined rejection from write should cause pipeTo() to reject when preventCancel is true: FAIL
an undefined rejection from write should cause pipeTo() to reject when preventCancel is false: FAIL
pipeTo() should reject if an option getter grabs a writer: FAIL
/streams/piping/general.any.worker.html
Piping must lock both the ReadableStream and WritableStream: FAIL
Piping finishing must unlock both the ReadableStream and WritableStream: FAIL
pipeTo must check the brand of its ReadableStream this value: FAIL
pipeTo must check the brand of its WritableStream argument: FAIL
pipeTo must fail if the ReadableStream is locked, and not lock the WritableStream: FAIL
pipeTo must fail if the WritableStream is locked, and not lock the ReadableStream: FAIL
Piping from a ReadableStream from which lots of chunks are synchronously readable: FAIL
Piping from a ReadableStream for which a chunk becomes asynchronously readable after the pipeTo: FAIL
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is true: FAIL
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is false: FAIL
an undefined rejection from write should cause pipeTo() to reject when preventCancel is true: FAIL
an undefined rejection from write should cause pipeTo() to reject when preventCancel is false: FAIL
pipeTo() should reject if an option getter grabs a writer: FAIL
/streams/piping/general.any.html
Piping must lock both the ReadableStream and WritableStream: FAIL
Piping finishing must unlock both the ReadableStream and WritableStream: FAIL
pipeTo must check the brand of its ReadableStream this value: FAIL
pipeTo must check the brand of its WritableStream argument: FAIL
pipeTo must fail if the ReadableStream is locked, and not lock the WritableStream: FAIL
pipeTo must fail if the WritableStream is locked, and not lock the ReadableStream: FAIL
Piping from a ReadableStream from which lots of chunks are synchronously readable: FAIL
Piping from a ReadableStream for which a chunk becomes asynchronously readable after the pipeTo: FAIL
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is true: FAIL
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is false: FAIL
an undefined rejection from write should cause pipeTo() to reject when preventCancel is true: FAIL
an undefined rejection from write should cause pipeTo() to reject when preventCancel is false: FAIL
pipeTo() should reject if an option getter grabs a writer: FAIL

New Tests That Don't Pass

/streams/piping/general.any.sharedworker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
Piping must lock both the ReadableStream and WritableStream: FAIL (Chrome: PASS)
Piping finishing must unlock both the ReadableStream and WritableStream: FAIL (Chrome: PASS)
pipeTo must check the brand of its ReadableStream this value: FAIL (Chrome: PASS)
pipeTo must check the brand of its WritableStream argument: FAIL (Chrome: PASS)
pipeTo must fail if the ReadableStream is locked, and not lock the WritableStream: FAIL (Chrome: PASS)
pipeTo must fail if the WritableStream is locked, and not lock the ReadableStream: FAIL (Chrome: PASS)
Piping from a ReadableStream from which lots of chunks are synchronously readable: FAIL (Chrome: PASS)
Piping from a ReadableStream for which a chunk becomes asynchronously readable after the pipeTo: FAIL (Chrome: PASS)
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is true: FAIL (Chrome: PASS)
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is false: FAIL (Chrome: PASS)
an undefined rejection from write should cause pipeTo() to reject when preventCancel is true: FAIL (Chrome: PASS)
an undefined rejection from write should cause pipeTo() to reject when preventCancel is false: FAIL (Chrome: PASS)
pipeTo() should reject if an option getter grabs a writer: FAIL (Chrome: PASS)
pipeTo() promise should resolve if null is passed: FAIL (Chrome: FAIL)
/streams/piping/general.any.serviceworker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Piping must lock both the ReadableStream and WritableStream: FAIL (Chrome: PASS, Safari: PASS)
Piping finishing must unlock both the ReadableStream and WritableStream: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must check the brand of its ReadableStream this value: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must check the brand of its WritableStream argument: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must fail if the ReadableStream is locked, and not lock the WritableStream: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must fail if the WritableStream is locked, and not lock the ReadableStream: FAIL (Chrome: PASS, Safari: PASS)
Piping from a ReadableStream from which lots of chunks are synchronously readable: FAIL (Chrome: PASS, Safari: PASS)
Piping from a ReadableStream for which a chunk becomes asynchronously readable after the pipeTo: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is true: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is false: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from write should cause pipeTo() to reject when preventCancel is true: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from write should cause pipeTo() to reject when preventCancel is false: FAIL (Chrome: PASS, Safari: PASS)
pipeTo() should reject if an option getter grabs a writer: FAIL (Chrome: PASS, Safari: PASS)
pipeTo() promise should resolve if null is passed: FAIL (Chrome: FAIL, Safari: FAIL)
/streams/piping/general.any.js: SKIP (Chrome: SKIP, Safari: SKIP)
/streams/piping/general.any.worker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Piping must lock both the ReadableStream and WritableStream: FAIL (Chrome: PASS, Safari: PASS)
Piping finishing must unlock both the ReadableStream and WritableStream: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must check the brand of its ReadableStream this value: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must check the brand of its WritableStream argument: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must fail if the ReadableStream is locked, and not lock the WritableStream: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must fail if the WritableStream is locked, and not lock the ReadableStream: FAIL (Chrome: PASS, Safari: PASS)
Piping from a ReadableStream from which lots of chunks are synchronously readable: FAIL (Chrome: PASS, Safari: PASS)
Piping from a ReadableStream for which a chunk becomes asynchronously readable after the pipeTo: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is true: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is false: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from write should cause pipeTo() to reject when preventCancel is true: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from write should cause pipeTo() to reject when preventCancel is false: FAIL (Chrome: PASS, Safari: PASS)
pipeTo() should reject if an option getter grabs a writer: FAIL (Chrome: PASS, Safari: PASS)
pipeTo() promise should resolve if null is passed: FAIL (Chrome: FAIL, Safari: FAIL)
/streams/piping/general.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Piping must lock both the ReadableStream and WritableStream: FAIL (Chrome: PASS, Safari: PASS)
Piping finishing must unlock both the ReadableStream and WritableStream: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must check the brand of its ReadableStream this value: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must check the brand of its WritableStream argument: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must fail if the ReadableStream is locked, and not lock the WritableStream: FAIL (Chrome: PASS, Safari: PASS)
pipeTo must fail if the WritableStream is locked, and not lock the ReadableStream: FAIL (Chrome: PASS, Safari: PASS)
Piping from a ReadableStream from which lots of chunks are synchronously readable: FAIL (Chrome: PASS, Safari: PASS)
Piping from a ReadableStream for which a chunk becomes asynchronously readable after the pipeTo: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is true: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from pull should cause pipeTo() to reject when preventAbort is false: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from write should cause pipeTo() to reject when preventCancel is true: FAIL (Chrome: PASS, Safari: PASS)
an undefined rejection from write should cause pipeTo() to reject when preventCancel is false: FAIL (Chrome: PASS, Safari: PASS)
pipeTo() should reject if an option getter grabs a writer: FAIL (Chrome: PASS, Safari: PASS)
pipeTo() promise should resolve if null is passed: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/streams/piping/general.any.sharedworker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
/streams/piping/general.any.serviceworker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/streams/piping/general.any.js: SKIP (Chrome: SKIP, Safari: SKIP)
/streams/piping/general.any.worker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/streams/piping/general.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b31205533233
[wpt PR 26251] - Add StreamPipeOptions to Readable Streams, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b31205533233

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.