Closed Bug 1672985 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26256 - Tweak flexbox_justifycontent-center-overflow.html to match implementations

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26256 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26256
Details from upstream follow.

b'Philip J\xc3\xa4genstedt <philip@foolip.org>' wrote:

Tweak flexbox_justifycontent-center-overflow.html to match implementations

The offsets -2.85em and 4.95em in the ref perhaps (at a guess) initially
matched precisely the Presto behavior, but now look like magic
constants, and slighly off in all implementations:
https://wpt.fyi/results/css/css-flexbox/flexbox_justifycontent-center-overflow.html?run_id=711240001&run_id=697770002&run_id=737900001&run_id=715540002&run_id=705490001

Control the width of the boxes more explicitly, so that the ref can be
written in a more straightforward way.

Also replaces "dam" (lady in Norwegian) with "x" to make the text much
shorter than the span widths, and matching an earlier rewrite:
https://github.com/web-platform-tests/wpt/pull/16820

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27b5977be506
[wpt PR 26256] - Tweak flexbox_justifycontent-center-overflow.html to match implementations, a=testonly
https://hg.mozilla.org/integration/autoland/rev/5ac62219b4bf
[wpt PR 26256] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/27b5977be506
https://hg.mozilla.org/mozilla-central/rev/5ac62219b4bf

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.