1672990 - RLB testing API should not require the "ping name"

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

The RLB Specific metric APIs currently require users to specify the name of the store they want to check for stored value. Other language bindings automatically check in the first store specified in the send_in_pings.

We should provide the same friendly API here, too.

Comment 1

[Alessio Placitelli [:Dexter]]

I think we have two choices here:

pub trait Boolean {
    // Will default to returning the value from `send_in_pings[0]`
    fn test_get_value(&self) -> Option<bool>;

    fn test_get_value_from_store(&self, storage_name: &str) -> Option<bool>;
}

or

pub trait Boolean {
    //  Will return the value from `send_in_pings[0]` if `storage_name` is `None`
    fn test_get_value(&self, storage_name: Option<&str>) -> Option<bool>;
}

I have a slight preference for the second option. What do you think, Jan-Erik?

Comment 2

[Jan-Erik Rediger [:janerik]]

Option 2 is more Rusty.

This should probably be generic to make it easier for users:

pub trait Boolean {
    //  Will return the value from `send_in_pings[0]` if `storage_name` is `None`
    fn test_get_value<'a, S: Into<Option<&'a str>>>(&self, storage_name: S) -> Option<bool>;
}

See this example for the possibilities: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=cf67b81f9d01b892b41ec87af294a596

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1287