1672995 - Port bug 1559181 to Thunderbird - Loading chrome pages blocked by about: policies never complete

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task, P1)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1559181 +++

This is at least making the comm/mail/components/enterprisepolicies/tests/browser/browser_policy_block_about.js test fail

Comment 1

[Mike Kaply [:mkaply]]

Sorry about that. I have a local Thunderbird build. I'll take a look.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Patch for about

I think this will do it, but thunderbird tests aren't running locally for me.

There's a new function on nsIAboutModule that retrieves the chrome URI so we can block it in addition to the about: version.

The test itself doesn't need much change (although it can be rewritten to test the chrome URLs as well)

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: thunderbird.diff

I did some addititions/modifications and now the test passes.

I don't quite understand why Firefox don't need to have a PromiseTestUtils.expectUncaughtRejection call for the blocked requests. But maybe it's there somewhere and I'm just not seeing it... Seems correct that it should be there though and the test doesn't pass without it.

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 9183548 [details] [diff] [review]
thunderbird.diff

Thanks for correcting my mistakes

LGTM.

I wonder if one of those about pages doesn't explicitly in Thunderbird?

Either way, you're right, better safe than sorry.

Comment 5

[Magnus Melin [:mkmelin]]

(In reply to Mike Kaply [:mkaply] from comment #4)

Thanks for correcting my mistakes

Thanks for the initial patch! :)

I wonder if one of those about pages doesn't explicitly in Thunderbird?

I think some word is missing here? What did you mean to ask?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ec2929c05e02
Port bug 1559181 to Thunderbird - Loading chrome pages blocked by about: policies never complete. r=mkaply

Comment 7

[Intermittent Failures Robot]

4 failures in 4230 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 4

Platform breakdown:

• windows7-32-shippable: 1
• macosx1014-64-shippable: 1
• linux64-shippable: 1
• windows10-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1672995&startday=2020-10-19&endday=2020-10-25&tree=all