Closed Bug 1673032 Opened 1 year ago Closed 1 year ago

Support nearbyIntDouble and nearbyIntFloat32 for ARM64

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(2 files)

nearbyInt(Double|Float32) can be implemented through frintp / frintm / frintn / frintz.

Summary: Support nearbyIntDouble and nearbyIntFloat32 for AMR64 → Support nearbyIntDouble and nearbyIntFloat32 for ARM64

HasRoundInstruction() and nearbyInt{Float32,Double}() are defined on all
platforms, so we no longer need to guard them through #ifdefs.

This change also allows to optimise round instructions on ARM64.

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1233c70a244d
Part 2: Remove ifdefs around assembler rounding functions. r=lth,jandem
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fdc073b9ef2
Support nearbyIntDouble and nearbyIntFloat32 for AMR64. r=jandem
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.