1673046 - Tweak menu separator line color on Big Sur some more

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, task)

Description

[Markus Stange [:mstange]]

The current color doesn't adapt to the background quite the same way the native one does.

The menu has a vibrancy effect, and its background color depends not just on the color immediately behind the menu, but also on the color of the desktop background.
I've checked the colors with various combinations of gray background colors:

Desktop background color	Behind-menu background color	Resulting menu background color	Separator line color
0	0	168	142
0	255	225	199
255	0	181	155
255	255	238	212

(It would be nice if we could use some simple arithmetic to get the actual separator RGBA values from this, but the window is composited with a vibrant blend mode, so this becomes a lot harder.)

I also took a screenshot of a native context menu window using Cmd+Shift+4,Space, which eliminates the vibrant blend mode and adds a solid backdrop.

Solidified background: 231
Separator on top of solidified background: 205

With this in mind, I want to change the separator color to 0.0, 0.0, 0.0, (231 - 205) / 231.0.

Before patch: 211, 211, 211, 211, 211
After patch: 149, 199, 160, 211, 205
Ideal colors: 142, 199, 155, 212, 205

So even with the patch we're still slightly too bright in some cases but I don't quite understand why. But it should be close enough.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1673046 - Change the menu separator color to a transparent black. r=haik

This matches the native appearance more closely.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca7ab23a5cef
Change the menu separator color to a transparent black. r=haik

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/ca7ab23a5cef

Comment 4

[Haik Aftandilian [:haik]]

We should uplift this to ESR 78. Bug 1656301 and bug 1668493 are already in.

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 9183492 [details]
Bug 1673046 - Change the menu separator color to a transparent black. r=haik

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Compatibility for new OS release
• User impact if declined: Visual imperfection on macOS Big Sur
• Fix Landed on Version: 84
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Tiny color tweak
• String or UUID changes made by this patch:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta too.

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 9183492 [details]
Bug 1673046 - Change the menu separator color to a transparent black. r=haik

same request details as comment 5

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9183492 [details]
Bug 1673046 - Change the menu separator color to a transparent black. r=haik

Polishing fix, approved for 83 beta 5, thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e07408b0b776

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 9183492 [details]
Bug 1673046 - Change the menu separator color to a transparent black. r=haik

approved for 78.5

Comment 11

[Peter Magyari (Desktop QA)]

Verified the fix on Firefox Nightly 84.0a1 (20201029095639) and Firefox Beta 83.0b5 (20201027175448)

Comment 12

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/15492a5c3af1

Comment 13

[Peter Magyari (Desktop QA)]

Verified the fix on Firefox 78.5.0esr (20201029151426)