[wpt-sync] Sync PR 26205 - [CSS] Apply first line style even if there are out-of-flow blocks
Categories
(Core :: Layout: Generated Content, Lists, and Counters, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 26205 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/26205
Details from upstream follow.
b'Jaeyong Bae <jdragon.bae@gmail.com>' wrote:
[CSS] Apply first line style even if there are out-of-flow blocks
This patch means the code change to apply first line style on the first
innermost in-flow block even if there are out-of-flow blocks.
Following the spec (https://drafts.csswg.org/css-pseudo-4/#first-line-pseudo),
The first formatted line of an element must occur inside a block-level
descendant in the same flow (that is not out-of-flow due to floating or
positioning). So, we should skip out-of-flow children in
LayoutBlock::EnclosingFirstLineStyleBlock().Bug: 979253
Change-Id: I58836b223b58816f731096a7a9f93e612278d42f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485667
Commit-Queue: Jaeyong Bae \<jdragon.bae@gmail.com>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820337}
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=303a219cbf11ce5eb5976f51b2c95b07dd7024c6
|
|
Assignee | |
Comment 2•4 years ago
|
||
CI Results
Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 3 tests
Status Summary
Firefox
FAIL: 3
Chrome
FAIL: 3
Safari
FAIL: 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/css/css-pseudo/first-line-with-out-of-flow-and-nested-div.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/first-line-with-out-of-flow-and-nested-span.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/first-line-with-out-of-flow.html: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b7b1253772d [wpt PR 26205] - [CSS] Apply first line style even if there are out-of-flow blocks, a=testonly https://hg.mozilla.org/integration/autoland/rev/79226cfcbbee [wpt PR 26205] - Update wpt metadata, a=testonly
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6b7b1253772d
https://hg.mozilla.org/mozilla-central/rev/79226cfcbbee
Description
•