Closed Bug 1673138 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26208 - [css-flex] Fix a test that had bad expectations

Categories

(Core :: Layout: Flexbox, task, P4)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26208 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26208
Details from upstream follow.

b'David Grogan <dgrogan@chromium.org>' wrote:

[css-flex] Fix a test that had bad expectations

Some hand calculations in the reference didn't age well. I replaced the
-ref.html with checkLayout.

The test failed in Firefox in an identical fashion. New test passes in
both browsers.

Just a test, no behavior change.

Fixed: 1111708
Change-Id: I7fc82e5d990c57db6c0d205e30aacaed88990418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490251
Commit-Queue: David Grogan \<dgrogan@chromium.org>
Reviewed-by: Christian Biesinger \<cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820506}

PR 26208 applied with additional changes from upstream: a10802c3fb44605290b78773eb0080c75be8538c
Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PASS: 3

Chrome

OK : 1
PASS: 3

Safari

OK : 1
PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e35dc57ff223
[wpt PR 26208] - [css-flex] Fix a test that had bad expectations, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.