1673313 - [Wayland] Crash at mozilla::widget::WaylandShmPool::WaylandShmPool

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

When Shm allocation fails Firefox on Wayland crashes. We should relax that and allow to report such failure.

Comment 1

[Ronald]

Thanks for the letting know us about this bug https://www.oursainsburys.biz/

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1673313 [Wayland] Don't fail when Shm allocation fails, r?jhorak

• Make WaylandAllocateShmMemory() fallible.
• Implement WaylandReAllocateShmMemory() to re-allocate Shm pool.
• Remove WaylandShmPool::Resize() and use WaylandShmPool::Create() only.
• Implement and use WaylandShmPool::Release().
• Make WindowSurfaceWayland::CreateWaylandBuffer() as fallible.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dff839f08039
[Wayland] Don't fail when Shm allocation fails, r=jhorak

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset dff839f08039 (Bug 1673313) for causing bustages in WindowSurfaceWayland

Backout link: https://hg.mozilla.org/integration/autoland/rev/cd9aab326ed69730e655d4ced8764effd172f67c

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=dotQG2f4QZicQwGMnwciWg.0&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=dff839f08039beb0d8db6c46daf956b6dfe87fc8

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319874455&repo=autoland&lineNumber=32482

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Updated, Thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6a1286e25b7
[Wayland] Don't fail when Shm allocation fails, r=jhorak

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e6a1286e25b7