1673342 - Support software WebRender with CompositorOGL on Android and Linux

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

It is nice if ASurfaceControl could be used for software WebRender.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1673342 - Use ASurfaceControl for software WebRender

Comment 2

[Sotaro Ikeda [:sotaro]]

I confirmed that RenderCompositorSWGL could directly render to Android hardware buffer. But we need to convert from BGRA to RGBA by using gfxUtils::ConvertBGRAtoRGBA(), since android hardware buffer does not support BGRA format and RenderCompositorSWGL supports only BGRA.

Comment 3

[Sotaro Ikeda [:sotaro]]

:lsalzman, :jrmuizel, is it possible to add RGBA support to RenderCompositorSWGL? Android hardware buffer does not support BGRA format.

Comment 4

[Sotaro Ikeda [:sotaro]]

:mattwoodrow, :jrmuizel, is it OK to use CompositorOGL on android for Software WebRender like RenderCompositorD3D11SWGL? It uses CompositorD3D11. Software WebRender only supports BGRA. When all rendering is done only by Software, we need to convert from BGRA to RGBA.

When CompositorOGL is used, we could handle SurfaceTexture rendering simply.

Comment 5

[Matt Woodrow (:mattwoodrow)]

I think there was a hope that we could avoid needing software webrender on Android at all, and ship hardware to 100% of our userbase.

If we have reason to believe that won't be possible, then I think using CompositorOGL should be fine (and is closer to what we current ship than RenderCompositorSWGL would be).

I think we could just rename RenderCompositorD3D11SWGL mostly to make a more generic type that targets the layers::Compositor API. There might be a few special cases for external compositor surfaces etc, but hopefully not a lot.

Comment 6

[Sotaro Ikeda [:sotaro]]

Thank you for the advice!

Comment 7

[Lee Salzman [:lsalzman]]

If necessary we might be able to make the SW compositor do the swizzle, but it's essentially turning every memcpy into a swizzle with the associated cost. If we #ifdef it at compile time for Android then it probably wouldn't be so horrible in terms of code-complexity, whereas it would be much harder to make compositing RGBA vs BGRA a runtime toggle. If we could rely on accelerated compositing on Android that may be a better scenario since Android hardware is already severely limited as it is.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Yep, what Matt said.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1673342 - Support software WebRender on Android and Linux

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1673342 - Add Support of software WebRender with CompositorOGL on Android and Linux

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2a11810933e
Add Support of software WebRender with CompositorOGL on Android and Linux r=mattwoodrow

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c2a11810933e