Closed Bug 1673346 Opened 4 years ago Closed 4 years ago

Glean component doesn't exist when Firefox is built without telemetry, leading to console errors

Categories

(Toolkit :: Telemetry, defect, P1)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: Gijs, Assigned: chutten)

Details

Attachments

(1 file)

Browser console error, spotted on an Ubuntu distro build:

Cc['@mozilla.org/toolkit/glean;1'] is undefined BrowserGlue.jsm:2603
    task resource:///modules/BrowserGlue.jsm:2603
    _scheduleStartupIdleTasks resource:///modules/BrowserGlue.jsm:2637

We should either be checking this before using it, or making sure it is always packaged but no-ops / doesn't send data if disabled.

Right. I think I'll throw some checks for MOZ_GLEAN around that task to sort this out. Thanks for catching this!

Assignee: nobody → chutten
Severity: -- → S3
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/91e7a297254e
Don't init FOG if not MOZ_GLEAN r=janerik
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: