Stop using devtools-launchpad in debugger webpack config
Categories
(DevTools :: Debugger, task, P3)
Tracking
(firefox84 fixed)
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(2 files)
we shouldn't need the launchpad here https://searchfox.org/mozilla-central/rev/e1d1f043957191616721b9e8bf811c0aab8a203a/devtools/client/debugger/webpack.config.js#5
|
||
Comment 1•4 years ago
|
||
Thanks for working on this Nicolas!
Honza
|
Assignee | |
Comment 2•4 years ago
|
||
This patch is simply inlining what was in devtools-launchpad directly into the
debugger's webpack config.
In order for the bundling script to still work, we had to add the dependencies
that were used in devtools-launchpad.
For some reason, this shifted a lot of modules in the generated files (but files
have the same size before and after, so I guess nothing changed).
Next patch in the serie will cleanup this webpack config.
|
|
Assignee | |
Comment 3•4 years ago
|
||
I inlined the two existing functinos that were modifying the base config directly
back into the base webpack config, and then removed everything that wasn't hit
or used by the bundling script.
Thanks to this work, we're able to remove a few files that were previously only
used in Launchpad, or that are simple enough to be inlined into the webpack config.
Depends on D96017
|
||
Updated•4 years ago
|
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38f88d3710f0 [devtools] Remove dependency on devtools-launchpad in webpack config. jdescottes. r=jdescottes https://hg.mozilla.org/integration/autoland/rev/599369e66c17 [devtools] Remove unnecessary parts of debugger's webpack config. r=jdescottes
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/38f88d3710f0
https://hg.mozilla.org/mozilla-central/rev/599369e66c17
Description
•