1673381 - symbolication lookup fails if there are no line records for FUNC

Status: RESOLVED FIXED

(Tecken :: Symbolication, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Tecken can symbolicate FUNC symbols that have no line records, but Eliot which uses Symbolic can't.

We can build a stack using the 091e54f9-c436-403a-8f17-704e80201023 crash report.

Tecken gets this:

{
  "frame": 3,
  "function": "thread_start<unsigned int (__cdecl*)(void *),
  "function_offset": "0x41",
  "module": "ucrtbase.pdb",
  "module_offset": "0x210b1"
},

and Eliot gets this:

{
  "frame": 3,
  "function": "ui64toa_s",
  "function_offset": "0x271",
  "line": 0,
  "module": "ucrtbase.pdb",
  "module_offset": "0x210b1"
},

The sym file at that point is this:

PUBLIC 20e40 0 ui64toa_s
FUNC 20e5c 55 0 common_xtox_s<unsigned __int64,char>
FUNC 20eb8 ab 0 common_xtox<unsigned __int64,char>
FUNC 20f70 95 0 beginthreadex
FUNC 2100c 5d 0 create_thread_parameter
FUNC 21070 9f 0 thread_start<unsigned int (__cdecl*)(void *),1> 

Symbolic issue: https://github.com/getsentry/symbolic/issues/284

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This may be another case of this issue, but maybe not.

stack 0, frame 5
**********
{
  "frame": 5,
  "function": "gtk_socket_add_id",
  "function_offset": "0x2e12a",
  "module": "libgtk-3.so.0.2404.19",
  "module_offset": "0x421f5a"
}
---
{
  "frame": 5,
  "module": "libgtk-3.so.0.2404.19",
  "module_offset": "0x421f5a"
}
**********

https://crash-stats.mozilla.org/report/index/468e0176-6dbc-4624-a1f8-360670201026
libgtk-3.so.0.2404.19/BEE13433AE94FF5EA56874D172A4F7E30: https://symbols.mozilla.org/libgtk-3.so.0.2404.19/BEE13433AE94FF5EA56874D172A4F7E30/libgtk-3.so.0.2404.19.sym

Relevant part of libgtk-3.s0.0.2404.19.sym:

...
PUBLIC 3f3e30 0 gtk_socket_add_id
STACK CFI INIT 82020 19 $r12: .cfa -40 + ^ $r13: .cfa -32 + ^ $r14: .cfa -24 + ^ $r15: .cfa -16 + ^ $rbp: .cfa -48 + ^ $rbx: .cfa -56 + ^ .cfa: $rsp 176 + .ra: .cfa -8 + ^
...

There are no FILE lines--just PUBLIC lines and then STACK lines.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

The upstream bug is closed and symbolic 8.0.4 is out which includes the fix.

This is up for retesting.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I tested this with the stack we had problems with and it's all good. Marking as FIXED.