1673388 - Print button appears enabled but does nothing when clicked, if added to the toolbar

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1670907 +++

Affected versions
82/83/84

Affected platforms

• macOS 10.14
• Ubuntu 18.04
• Windows 10x64
• Windows 7x64

Steps to reproduce

1. Launch FF.
2. Go to the burger menu
3. Go to Customize.
4. Put the Print button anywhere on the Toolbar.

Expected result

• Button is active and can be interacted with as soon as it has been set on the toolbar.

Actual result

• Button is not greyed out, but still doesn't do anything when clicked / activated.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1673388 - use keepbroadcastattributeswhencustomizing for the print button to make it behave better wrt customize mode, r?mconley

Embarrassingly, I forgot I added this in bug 1388990 when we had similar issues
with the back/forward buttons. It's a more straightforward solution for this
problem.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daeedbe39586
use keepbroadcastattributeswhencustomizing for the print button to make it behave better wrt customize mode, r=mconley

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/daeedbe39586

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

Gijs, should we uplift this fix to beta?

Comment 5

[:Gijs (he/him)]

Comment on attachment 9183794 [details]
Bug 1673388 - use keepbroadcastattributeswhencustomizing for the print button to make it behave better wrt customize mode, r?mconley

Beta/Release Uplift Approval Request

• User impact if declined: Broken print button if it's moved in customize mode
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment #0
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): There are automated tests, and it's mostly a revert of code from bug 1670907, substituting it with a one-line attribute addition that is existing code used for the back/fwd buttons. That said, I thought this had been fixed in 1670907 so we should really try and get manual QE to doublecheck that I really haven't imagined it this time...
• String changes made/needed: no

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9183794 [details]
Bug 1673388 - use keepbroadcastattributeswhencustomizing for the print button to make it behave better wrt customize mode, r?mconley

Approved for 83 beta 6, thanks.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/697761ce0485

Comment 8

[Alin Ilea, Desktop QA]

Reproduced the initial issue in Beta 83.0b5 using Windows 10.
Verified - Fixed in latest Nightly 84.0a1 (build id: 20201029040710) and Beta 83.0b6 (build id: 20201028180355), using Windows 10, Windows 7 and Ubuntu 18.04.