167339 - Dragging personal toolbar folder into self causes crash on manage or file bookmarks

Status: RESOLVED DUPLICATE of bug 109237

(SeaMonkey :: Bookmarks & History, defect)

Description

[j13moh]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826

It is possible to accidentally drag the personal toolbar into itself, creating a
situation where it is impossible to file or delete bookmarks using the browser's
interface without the browser freezing.

I presume this is caused by infinite recursion caused by something in the
personal toolbar folder linking back to itself.

Reproducible: Always

Steps to Reproduce:
1. Start mozilla and set up a personal toolbar folder with some random items in it.

2. In the browser window, make sure the personal toolbar item is visible. 
(Selectable from view > show/hide > personal toolbar)  You should see those
random items you added visible at the top of the browser screen.

3. Backup your bookmarks now because the next step will damage them and cause
the browser to crash.

4. Click + drag on a blank part of the personal toolbar item referenced in step
#2, and drag it onto itself between two of the pre-existing items, so that it
appears as a clickable item on the toolbar.

5. Try to select bookmarks > manage bookmarks or file a bookmark.  The browser
will freeze.  It is impossible to recover from this through the browser interface.

6. Fix the problem by manually copying back your saved bookmarks.html file into
your profile directory.
Actual Results:  
The browser freezes and it is impossible to fix the situation for the unskilled
end user without creating a new profile.

Expected Results:  
The user should not have been allowed to drag the personal toolbar folder into
itself.

This had me stumped for a few days until I realised what happenned and manually
edited bookmarks.html to un-enable the accidentally-added item as the personal
toolbar folder.

Comment 1

[j13moh]

Here are some talkback crashes filed as a result of crashes from this big
(before I realised the cause of the problem)

TB10475787X
TB10475626X
TB10449500X
TB10449371K
TB10446485M

Comment 2

[Chris Lyon]

*** This bug has been marked as a duplicate of 109237 ***

Comment 3

[j13moh]

Sorry for the dupe, I did search for it.