16734 - Alt-e-e backwards compatibility

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Judson Valeski]

In 4.x- the keystroke alt-e-e (alt-e, e) used to work (take you immediately to
the prefs pane). Today, alt-e does the right thing, but the preferences menu
item uses the 'f' shortcut char instead of 'e'. Also, you have to press enter
once the menu item is sected. Selection of the shortcut char, (currently 'f';
needs to be 'e') should envoke the menu item, rather than the return key.

Comment 1

[davidm]

m20

Comment 2

[davidm]

reassign to UE since they have to update the spec since the spec says f before I
make this change.  If you feel there is a bug in how access keys are dispatched
file it against XPToolkit.

Comment 3

[shuang (gone)]

reassign it to german to check out his menu spec

Comment 4

[german]

accepting the bug, making change to menu spec shortly

Comment 5

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.

Comment 6

[timeless]

as of 20000528 win32
alt-e,f does not require an <enter> key.

Comment 7

[Judson Valeski]

thank you for pointing that out. what file do I need to edit to change that 'f' 
to an 'e'?

Comment 8

[Judson Valeski]

nom. nsbeta2... don't laugh. this is a big deal to me. the change is trivial 
(zero risk) (one char). diff below. Technically speaking this is needed for 4.x 
backwards compat.

Index: utilityOverlay.dtd
===================================================================
RCS file: /cvsroot/mozilla/xpfe/communicator/resources/locale/en-US/utilityOverl
ay.dtd,v
retrieving revision 1.2
diff -c -r1.2 utilityOverlay.dtd
*** utilityOverlay.dtd  2000/06/05 06:27:31     1.2
--- utilityOverlay.dtd  2000/06/08 00:10:47
***************
*** 59,65 ****
  <!ENTITY selectAllCmd.accesskey                               "a">
  <!ENTITY preferencesCmd.label                         "Preferences...">
  <!ENTITY preferencesCmd.key                                   "E">
! <!ENTITY preferencesCmd.accesskey                     "f">

  <!ENTITY viewMenu.label                                       "View">
  <!ENTITY viewMenu.accesskey                           "v">
--- 59,65 ----
  <!ENTITY selectAllCmd.accesskey                               "a">
  <!ENTITY preferencesCmd.label                         "Preferences...">
  <!ENTITY preferencesCmd.key                                   "E">
! <!ENTITY preferencesCmd.accesskey                     "e">

  <!ENTITY viewMenu.label                                       "View">
  <!ENTITY viewMenu.accesskey                           "v">

Comment 9

[leger]

Putting on [nsbeta2-] radar. Not critical to beta2.

Comment 10

[Judson Valeski]

fix is in

Comment 11

[Matthew T (active 1999-2002)]

Mac menus don't have mnemonics, so I can't test this. QA --> Sarah.

Comment 12

[sairuh (rarely reading bugmail)]

vrfy on winnt, 2000.06.14.08-m17 commercial bits.