Closed
Bug 1673435
Opened 4 years ago
Closed 4 years ago
Don't print out nsISupports in XPCWrappedNative::ToString() unless it is the only interface
Categories
(Core :: XPConnect, task, P3)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
The first interface in every XPCWN is nsISupports, so we don't need to print it out unless there's only a single interface. We can also take advantage of this to remove the call to XPCNativeInterface::GetISupports(cx), which in turn lets us remove the cx argument to this method.
|
Assignee | |
Updated•4 years ago
|
Summary: Don't print out nsISupports XPCWrappedNative::ToString() unless it is the only interface → Don't print out nsISupports in XPCWrappedNative::ToString() unless it is the only interface
|
|
Assignee | |
Comment 1•4 years ago
|
||
The first interface is always nsISupports, so there's no need
for the check here. This lets me remove the cx argument.
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff1d1aec8c32 Don't print out nsISupports in XPCWrappedNative::ToString() unless it is the only interface. r=nika
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•