Closed Bug 1673438 Opened 5 years ago Closed 4 years ago

Refactor evaluate.fromJSON parameters into an "options" object

Categories

(Remote Protocol :: Marionette, task, P5)

Product:
Remote Protocol
Component:
Marionette
Type:
task

Tracking

(firefox96 fixed)

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: impossibus, Assigned: onuohaoluebube05, Mentored)

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

Bug 1673438 -[remote] Refactored evaluate.fromJSON parameters into an options object r=whimboo
48 bytes, text/x-phabricator-request
Details | Review

evaluate.fromJSON has some optional parameters. By making it accept a single object instead, we can take advantage of object destructuring as in e.g. https://searchfox.org/mozilla-central/rev/dbced93f1c57942501c23d4633d01ce59d9087a1/testing/marionette/actors/MarionetteFrameChild.jsm#236-237

Assignee: nobody → onuohaoluebube05
Status: NEW → ASSIGNED
Attachment #9247917 - Attachment description: Bug 1673438 - Refactored evaluate.fromJSON parameters into an options object r=whimboo → Bug 1673438 -[remote] Refactored evaluate.fromJSON parameters into an options object r=whimboo
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f4d24947f752 [remote] Refactored evaluate.fromJSON parameters into an options object r=whimboo,webdriver-reviewers

https://hg.mozilla.org/mozilla-central/rev/f4d24947f752

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: