1673533 - [wpt-sync] Sync PR 26301 - Revert "[GridNG] Implement alignment within grid-areas."

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 26301 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26301
Details from upstream follow.

b'Kunihiko Sakamoto <[e-mail]>' wrote:

Revert "[GridNG] Implement alignment within grid-areas."

This reverts commit f6a053018ae3a5fdfe08a0f1bb15ad61d79026cd.

Reason for revert: virtual/layout-ng-grid/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-*.html are failing in multiple bots.

https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/75331
https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/9841
https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/17342

Original change's description:

[GridNG] Implement alignment within grid-areas.

This patch implements alignment within a grid-item's grid-area.
When creating the GridItemData we read of the containers, and
grid-item's style, or determine its alignment axis-edge, and if it
should be stretched, saving this information on the GridItemData.

When placing the grid-item it will use this to adjust the offset.

This doesn't implement baseline alignment which requires a secondary
pass to correctly determine the baseline for the column/row.

The other TODO relates to the constraint-space API, and how grid will
need a slightly new concept in order to do block-axis stretching
easily. By default non-replaced grid-items will stretch to the available
space. A new bit on the space can indicate that we should stretch to
the available space (if possible), this is similar to the shrink-to-fit
bit we have today.

This adds a self-start/self-end test as after implementing this now new
tests passed immediately, and I don't believe we had good test
coverage for inflow content with these keywords.

Bug: 1045599
Change-Id: I8c9cc51381c3d75519e52b32472b58ec96a6a85a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492176
Commit-Queue: Ian Kilpatrick \<[e-mail]>
Reviewed-by: Christian Biesinger \<[e-mail]>
Reviewed-by: Kurt Catti-Schmidt \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#821043}

TBR=[e-mail],[e-mail],[e-mail],[e-mail]

Change-Id: I0a9398ce4bf339a632c3baed7374754f3c664496
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1045599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500969
Reviewed-by: Kunihiko Sakamoto \<[e-mail]>
Commit-Queue: Kunihiko Sakamoto \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#821074}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 26301 applied with additional changes from upstream: 75aeef19a407d18832cf0c3946781f97266f74a2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=52e11cfd1470dea3797831246d46b31024c52f0f

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/001e87b0435e
[wpt PR 26301] - Revert "[GridNG] Implement alignment within grid-areas.", a=testonly

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/001e87b0435e