Closed Bug 1673541 Opened 4 years ago Closed 4 years ago

Some MoveDenseElements cleanup

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(1 file)

Some minor follow-up changes I noticed for bug 1673221.

  • Change MoveDenseElements to return bool instead of DenseElementResult.
  • Add HandleArrayObject arr in a few places to make code more readable.
  • For step 16 in array_splice_impl call NativeObject::moveDenseElements directly so it's clear the fast path is fallible.
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be8fad9024b1
Clean up MoveDenseElements calls a bit. r=anba
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: